From cbff4ef859b72aa1bf0a147249ea46f3ba41b6ff Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Fri, 29 Mar 2019 14:42:07 -0400 Subject: [PATCH 1/3] Making use of ValidationMessage controls correctly --- .../Dialog/RepositoryCreationViewModel.cs | 3 - .../Views/Dialog/RepositoryCreationView.xaml | 461 +++++++++--------- 2 files changed, 232 insertions(+), 232 deletions(-) diff --git a/src/GitHub.App/ViewModels/Dialog/RepositoryCreationViewModel.cs b/src/GitHub.App/ViewModels/Dialog/RepositoryCreationViewModel.cs index 24b5a7d04c..e31758de75 100644 --- a/src/GitHub.App/ViewModels/Dialog/RepositoryCreationViewModel.cs +++ b/src/GitHub.App/ViewModels/Dialog/RepositoryCreationViewModel.cs @@ -90,9 +90,6 @@ public RepositoryCreationViewModel( return parsedReference != repoName ? String.Format(CultureInfo.CurrentCulture, Resources.SafeRepositoryNameWarning, parsedReference) : null; }); - this.WhenAny(x => x.BaseRepositoryPathValidator.ValidationResult, x => x.Value) - .Subscribe(); - CreateRepository = InitializeCreateRepositoryCommand(); isCreating = CreateRepository.IsExecuting diff --git a/src/GitHub.VisualStudio.UI/Views/Dialog/RepositoryCreationView.xaml b/src/GitHub.VisualStudio.UI/Views/Dialog/RepositoryCreationView.xaml index f70229d61e..71f7373b03 100644 --- a/src/GitHub.VisualStudio.UI/Views/Dialog/RepositoryCreationView.xaml +++ b/src/GitHub.VisualStudio.UI/Views/Dialog/RepositoryCreationView.xaml @@ -13,238 +13,241 @@ xmlns:vs="clr-namespace:Microsoft.VisualStudio.PlatformUI;assembly=Microsoft.VisualStudio.Shell.14.0" Background="{DynamicResource {x:Static vs:EnvironmentColors.ToolWindowBackgroundBrushKey}}" Foreground="{DynamicResource {x:Static vs:EnvironmentColors.ToolWindowTextBrushKey}}" - AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.RepositoryCreationControlCustom}" > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -