-
Notifications
You must be signed in to change notification settings - Fork 2k
Expand file tree
/
Copy pathroute-setups.js
More file actions
300 lines (283 loc) · 7.11 KB
/
route-setups.js
File metadata and controls
300 lines (283 loc) · 7.11 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
const express = require('express');
const TestObj = require('@example/test');
function basicTaint() {
const app = express();
app.use((req, res, next) => {
req.tainted = source();
req.safe = 'safe';
next();
});
app.get('/', (req, res) => {
sink(req.tainted); // NOT OK
sink(req.safe); // OK
});
}
function basicApiGraph() {
const app = express();
app.use((req, res, next) => {
req.obj = new TestObj();
next();
});
app.get('/', (req, res) => {
sink(req.obj.getSource()); // NOT OK
req.obj.getSink(source()); // NOT OK
});
}
function noTaint() {
const app = express();
function middleware(req, res, next) {
req.tainted = source();
req.safe = 'safe';
next();
}
app.get('/unsafe', middleware, (req, res) => {
sink(req.tainted); // NOT OK
sink(req.safe); // OK
});
app.get('/safe', (req, res) => {
sink(req.tainted); // OK - not preceded by middleware
sink(req.safe); // OK
});
}
function looseApiGraphStep() {
const app = express();
function middleware(req, res, next) {
req.obj = new TestObj();
next();
}
app.get('/unsafe', middleware, (req, res) => {
sink(req.obj.getSource()); // NOT OK
});
app.get('/safe', (req, res) => {
sink(req.obj.getSource()); // NOT OK - we allow API graph steps within the same app
});
}
function chainMiddlewares() {
const app = express();
function step1(req, res, next) {
req.taint = source();
next();
}
function step2(req, res, next) {
req.locals.alsoTaint = req.taint;
next();
}
app.get('/', step1, step2, (req, res) => {
sink(req.taint); // NOT OK
sink(req.locals.alsoTaint); // NOT OK
});
}
function routerEscapesIntoParameter() {
const app = express();
function setupMiddlewares(router) {
router.use((req, res, next) => {
req.taint = source();
next();
});
}
app.get('/before', (req, res) => {
sink(req.taint); // OK
});
setupMiddlewares(app);
app.get('/after', (req, res) => {
sink(req.taint); // NOT OK
});
}
function routerReturned() {
const app = express();
function makeMiddlewares() {
let router = new express.Router();
router.use((req, res, next) => {
req.taint = source();
next();
});
return router;
}
app.get('/before', (req, res) => {
sink(req.taint); // OK
});
app.use(makeMiddlewares());
app.get('/after', (req, res) => {
sink(req.taint); // NOT OK
});
}
function routerCaptured() {
const app = express();
function addMiddlewares() {
app.use((req, res, next) => {
req.taint = source();
next();
});
}
app.get('/before', (req, res) => {
sink(req.taint); // OK
});
addMiddlewares();
app.get('/after', (req, res) => {
sink(req.taint); // NOT OK
});
}
function withPath() {
const app = express();
app.use('/foo', (req, res, next) => {
req.taint = source();
next();
});
app.get('/foo', (req, res) => {
sink(req.taint); // NOT OK
});
app.get('/bar', (req, res) => {
sink(req.taint); // OK
});
}
function withNestedPath() {
const app = express();
app.use('/foo/bar', (req, res, next) => {
req.taint = source();
next();
});
function makeRouter() {
const router = express.Router();
router.get('/bar', (req, res) => {
sink(req.taint); // NOT OK
})
router.get('/baz', (req, res) => {
sink(req.taint); // OK
})
return router;
}
app.get('/foo', makeRouter());
app.get('/bar', (req, res) => {
sink(req.taint); // OK
});
}
function withHttpMethods() {
const app = express();
app.get('/foo', (req, res, next) => {
req.taintGet = source();
next();
});
app.post('/foo', (req, res, next) => {
req.taintPost = source();
next();
});
app.all('/foo', (req, res, next) => {
req.taintAll = source();
next();
});
app.get('/foo/a', (req, res) => {
sink(req.taintGet); // NOT OK
sink(req.taintPost); // OK - not tainted for GET requests
sink(req.taintAll); // NOT OK
});
app.post('/foo/b', (req, res) => {
sink(req.taintGet); // OK - not tainted for POST requests
sink(req.taintPost); // NOT OK
sink(req.taintAll); // NOT OK
});
app.all('/foo/c', (req, res) => {
sink(req.taintGet); // NOT OK
sink(req.taintPost); // NOT OK
sink(req.taintAll); // NOT OK
});
}
function withChaining() {
const app = express();
app.use('/', (req, res) => {
sink(req.taint); // OK
});
function middleware() {
return express.Router()
.use((req, res, next) => {
req.taint = source();
next();
})
.use(blah());
}
app.use(middleware());
app.use('/', (req, res) => {
sink(req.taint); // NOT OK
});
}
function withClass() {
class App {
constructor(router) {
this.router = router;
this.earlyRoutes();
this.addMiddleware();
this.lateRoutes();
}
earlyRoutes() {
this.router.get('/', (req, res) => {
sink(req.taint); // OK
})
}
addMiddleware() {
this.router.use((req, res, next) => {
req.taint = source();
next();
})
}
lateRoutes() {
this.router.get('/', (req, res) => {
sink(req.taint); // NOT OK
})
}
}
let app = new App(express());
}
function withArray() {
const app = express();
app.get('/before', (req, res) => {
sink(req.taint); // OK
});
app.use([
(req, res, next) => {
sink(req.taint); // OK
next();
},
(req, res, next) => {
req.taint = source();
next();
},
(req, res, next) => {
sink(req.taint); // NOT OK
next();
}
]);
app.get('/after', (req, res) => {
sink(req.taint); // NOT OK
});
}
function withForLoop() {
const app = express();
let middlewares = [
(req, res, next) => {
sink(req.taint); // OK
next();
},
(req, res, next) => {
req.taint = source();
next();
},
(req, res, next) => {
sink(req.taint); // NOT OK
next();
}
];
app.get('/before', (req, res) => {
sink(req.taint); // OK
});
for (let route of middlewares) {
app.use(route);
}
app.get('/after', (req, res) => {
sink(req.taint); // NOT OK
});
}
function routeHandlersInProps() {
let routes = require('./routes');
const app = express();
app.use(routes.first);
app.get('/', routes.second);
}