Ruby: avoid name clash for "assoc" summary

asgerf · asgerf · commit 0592c8ba99a4 · 2023-05-23T17:34:19.000+02:00
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/core/Hash.qll b/ruby/ql/lib/codeql/ruby/frameworks/core/Hash.qll
@@ -199,11 +199,13 @@ module Hash {
     }
   }
 
-  private class AssocUnknownSummary extends AssocSummary {
-    AssocUnknownSummary() {
-      this = "assoc" and
-      mc.getNumberOfArguments() = 1 and
-      not exists(DataFlow::Content::getKnownElementIndex(mc.getArgument(0)))
+  private class AssocUnknownSummary extends SummarizedCallable {
+    AssocUnknownSummary() { this = "assoc-unknown-arg" }
+
+    override MethodCall getACallSimple() {
+      result.getMethodName() = "assoc" and
+      result.getNumberOfArguments() = 1 and
+      not exists(DataFlow::Content::getKnownElementIndex(result.getArgument(0)))
     }
 
     override predicate propagatesFlowExt(string input, string output, boolean preservesValue) {

Original file line number	Diff line number	Diff line change
`@@ -199,11 +199,13 @@ module Hash {`
`199`	`199`	`}`
`200`	`200`	`}`
`201`	`201`
`202`		`- private class AssocUnknownSummary extends AssocSummary {`
`203`		`- AssocUnknownSummary() {`
`204`		`- this = "assoc" and`
`205`		`- mc.getNumberOfArguments() = 1 and`
`206`		`- not exists(DataFlow::Content::getKnownElementIndex(mc.getArgument(0)))`
	`202`	`+ private class AssocUnknownSummary extends SummarizedCallable {`
	`203`	`+ AssocUnknownSummary() { this = "assoc-unknown-arg" }`
	`204`	`+`
	`205`	`+ override MethodCall getACallSimple() {`
	`206`	`+ result.getMethodName() = "assoc" and`
	`207`	`+ result.getNumberOfArguments() = 1 and`
	`208`	`+ not exists(DataFlow::Content::getKnownElementIndex(result.getArgument(0)))`
`207`	`209`	`}`
`208`	`210`
`209`	`211`	`override predicate propagatesFlowExt(string input, string output, boolean preservesValue) {`