C++: Remove untested PostUpdateNode code for now, and field cases that don't work anyway.

geoffw0 · geoffw0 · commit 06d369ba1118 · 2024-04-08T16:05:18.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll
@@ -193,7 +193,6 @@ module SourceSinkInterpretationInput implements
       c = "" and
       n.asExpr().(VariableAccess).getTarget() = ast
     )
-    // TODO: source fields?
   }
 
   /** Provides additional source specification logic. */
@@ -204,11 +203,6 @@ module SourceSinkInterpretationInput implements
       ast = mid.asElement() and
       e.getTarget() = ast
     |
-      // Allow fields to be picked as input nodes.
-      // TODO: this has no test cases.
-      c = "" and
-      e.getQualifier() = n.asExpr()
-      or
       // Allow variables to be picked as input nodes.
       // We could simply do this as `e = n.asExpr()`, but that would not allow
       // us to pick `x` as a sink in an example such as `x = source()` (but
@@ -222,12 +216,6 @@ module SourceSinkInterpretationInput implements
         store.getDestinationAddress().getUnconvertedResultExpression() = e and
         n.asInstruction() = store
       )
-      or
-      // Allow post update nodes to be picked as input nodes when the `input` column
-      // of the row is `PostUpdate`.
-      // TODO: this has no test cases.
-      c = "PostUpdate" and
-      e.getQualifier() = n.(PostUpdateNode).getPreUpdateNode().asExpr()
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,6 @@ module SourceSinkInterpretationInput implements`
`193`	`193`	`c = "" and`
`194`	`194`	`n.asExpr().(VariableAccess).getTarget() = ast`
`195`	`195`	`)`
`196`		`- // TODO: source fields?`
`197`	`196`	`}`
`198`	`197`
`199`	`198`	`/** Provides additional source specification logic. */`
`@@ -204,11 +203,6 @@ module SourceSinkInterpretationInput implements`
`204`	`203`	`ast = mid.asElement() and`
`205`	`204`	`e.getTarget() = ast`
`206`	`205`	`\|`
`207`		`- // Allow fields to be picked as input nodes.`
`208`		`- // TODO: this has no test cases.`
`209`		`- c = "" and`
`210`		`- e.getQualifier() = n.asExpr()`
`211`		`- or`
`212`	`206`	`// Allow variables to be picked as input nodes.`
`213`	`207`	// We could simply do this as `e = n.asExpr()`, but that would not allow
`214`	`208`	// us to pick `x` as a sink in an example such as `x = source()` (but
`@@ -222,12 +216,6 @@ module SourceSinkInterpretationInput implements`
`222`	`216`	`store.getDestinationAddress().getUnconvertedResultExpression() = e and`
`223`	`217`	`n.asInstruction() = store`
`224`	`218`	`)`
`225`		`- or`
`226`		- // Allow post update nodes to be picked as input nodes when the `input` column
`227`		- // of the row is `PostUpdate`.
`228`		`- // TODO: this has no test cases.`
`229`		`- c = "PostUpdate" and`
`230`		`- e.getQualifier() = n.(PostUpdateNode).getPreUpdateNode().asExpr()`
`231`	`219`	`)`
`232`	`220`	`}`
`233`	`221`	`}`