C++: Add support for fgetws.

geoffw0 · geoffw0 · commit 06e649fc3074 · 2020-02-24T11:47:32.000Z
diff --git a/change-notes/1.24/analysis-cpp.md b/change-notes/1.24/analysis-cpp.md
@@ -42,7 +42,7 @@ The following changes in version 1.24 affect C/C++ analysis in all applications.
   * The `LocalScopeVariableReachability` library is deprecated in favor of
     `StackVariableReachability`. The functionality is the same.
 * The models library models `strlen` in more detail, and includes common variations such as `wcslen`.
-* The models library models `gets` and `fgets`.
+* The models library models `gets` and similar functions.
 * The taint tracking library (`semmle.code.cpp.dataflow.TaintTracking`) has had
   the following improvements:
   * The library now models data flow through `strdup` and similar functions.
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/Gets.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/Gets.qll
@@ -12,7 +12,8 @@ class GetsFunction extends DataFlowFunction, TaintFunction, ArrayFunction, Alias
   GetsFunction() {
     exists(string name | name = getName() |
       name = "gets" or // gets(str)
-      name = "fgets" // fgets(str, num, stream)
+      name = "fgets" or // fgets(str, num, stream)
+      name = "fgetws" // fgetws(wstr, num, stream)
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,8 @@ class GetsFunction extends DataFlowFunction, TaintFunction, ArrayFunction, Alias`
`12`	`12`	`GetsFunction() {`
`13`	`13`	`exists(string name \| name = getName() \|`
`14`	`14`	`name = "gets" or // gets(str)`
`15`		`- name = "fgets" // fgets(str, num, stream)`
	`15`	`+ name = "fgets" or // fgets(str, num, stream)`
	`16`	`+ name = "fgetws" // fgetws(wstr, num, stream)`
`16`	`17`	`)`
`17`	`18`	`}`
`18`	`19`