Kotlin: Handle /!unknown-binary-location/... paths specially on Windows

igfoo · igfoo · commit 0a470b086497 · 2022-10-26T19:20:32.000+01:00
The standard code wants to normalise it to C:/!unknown-binary-location/...
which is particularly annoying for cross-platform test output.
diff --git a/java/kotlin-extractor/src/main/java/com/semmle/util/trap/pathtransformers/PathTransformer.java b/java/kotlin-extractor/src/main/java/com/semmle/util/trap/pathtransformers/PathTransformer.java
@@ -14,7 +14,15 @@ public abstract class PathTransformer {
 	 * canonical, absolute, strings and normalises away Unix/Windows differences.
 	 */
 	public String fileAsDatabaseString(File file) {
-		String path;
+		String path = file.getPath();
+		// For a /!unknown-binary-location/... path, on Windows
+		// the standard code wants to normalise it to
+		// C:/!unknown-binary-location/...
+		// which is particularly annoying for cross-platform test
+		// output. We therefore handle it specially here.
+		if (path.matches("^[/\\\\]!unknown-binary-location[/\\\\].*")) {
+			return path.replace('\\', '/');
+		}
 		if (Boolean.valueOf(Env.systemEnv().get(Var.SEMMLE_PRESERVE_SYMLINKS)))
 			path = FileUtil.simplifyPath(file);
 		else
@@ -43,4 +51,4 @@ public File canonicalFile(String path) {
 	public static PathTransformer std() {
 		return DEFAULT_TRANSFORMER;
 	}
-}
+}
