Fixed issue where method calls weren't properly resolved when inheritance was implemented via prototype manipulation instead of ES6 class syntax.

Napalys · Napalys · commit 0a9a7911c2ec · 2025-04-29T12:39:44.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll b/javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll
@@ -1437,8 +1437,6 @@ module ClassNode {
       astNode instanceof ClassDefinition and
       result = astNode.(ClassDefinition).getSuperClass().flow()
       or
-      // Function-style class superclass patterns
-      astNode instanceof Function and
       (
         // C.prototype = Object.create(D.prototype)
         exists(DataFlow::InvokeNode objectCreate, DataFlow::PropRead superProto |
diff --git a/javascript/ql/test/library-tests/CallGraphs/AnnotatedTest/Test.expected b/javascript/ql/test/library-tests/CallGraphs/AnnotatedTest/Test.expected
@@ -2,7 +2,6 @@ spuriousCallee
 missingCallee
 | constructor-field.ts:40:5:40:14 | f3.build() | constructor-field.ts:13:3:13:12 | build() {} | -1 | calls |
 | constructor-field.ts:71:1:71:11 | bf3.build() | constructor-field.ts:13:3:13:12 | build() {} | -1 | calls |
-| prototypes.js:7:5:7:16 | this.greet() | prototypes.js:59:8:63:3 | () { \\n  ... ); \\n  } | -1 | calls |
 badAnnotation
 accessorCall
 | accessors.js:12:1:12:5 | obj.f | accessors.js:5:8:5:12 | () {} |

Original file line number	Diff line number	Diff line change
`@@ -1437,8 +1437,6 @@ module ClassNode {`
`1437`	`1437`	`astNode instanceof ClassDefinition and`
`1438`	`1438`	`result = astNode.(ClassDefinition).getSuperClass().flow()`
`1439`	`1439`	`or`
`1440`		`- // Function-style class superclass patterns`
`1441`		`- astNode instanceof Function and`
`1442`	`1440`	`(`
`1443`	`1441`	`// C.prototype = Object.create(D.prototype)`
`1444`	`1442`	`exists(DataFlow::InvokeNode objectCreate, DataFlow::PropRead superProto \|`