Python: Apply suggestions from code review

RasmusWL · yoff · web-flow · commit 0ade23ab2ad5 · 2021-05-18T11:49:59.000+02:00
Co-authored-by: yoff &lt;lerchedahl@gmail.com&gt;
diff --git a/python/ql/src/semmle/python/frameworks/Cryptodome.qll b/python/ql/src/semmle/python/frameworks/Cryptodome.qll
@@ -148,7 +148,7 @@ private module CryptodomeModel {
       result in [this.getArg(0), this.getArgByName("plaintext")]
       or
       methodName in ["decrypt_and_verify"] and
-      result in [this.getArg(0), this.getArgByName("ciphertext")]
+      result in [this.getArg(0), this.getArgByName("ciphertext"), this.getArg(1), this.getArgByName("mac_tag")]
     }
   }
 
diff --git a/python/ql/test/library-tests/frameworks/crypto/README.md b/python/ql/test/library-tests/frameworks/crypto/README.md
@@ -6,7 +6,7 @@ You can run the following command to update the tests:
 rm *.py && cp ../cryptodome/*.py . && sed -i -e 's/Cryptodome/Crypto/' *.py
 ```
 
-The original [`pycrypto` PyPI package](https://pypi.org/project/pycrypto/) that provided the `Crypto` Python package has not been updated since 2013, so it is reasonable to assume that people will use the replacement [`pycryptodome` PyPI package](https://pypi.org/project/pycryptodome/) that has a (mostly) compatible API.
+The original [`pycrypto` PyPI package](https://pypi.org/project/pycrypto/) that provided the `Crypto` Python package has not been updated since 2013, so it is reasonable to assume that people will use the replacement [`pycryptodome` PyPI package](https://pypi.org/project/pycryptodome/) that also provides a `Crypto` Python package and has a (mostly) compatible API.
 
 The pycryptodome functionality is also available in the [`pycryptodomex` PyPI package](https://pypi.org/project/pycryptodomex/) which provides the `Cryptodome` Python package.
 

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ private module CryptodomeModel {`
`148`	`148`	`result in [this.getArg(0), this.getArgByName("plaintext")]`
`149`	`149`	`or`
`150`	`150`	`methodName in ["decrypt_and_verify"] and`
`151`		`- result in [this.getArg(0), this.getArgByName("ciphertext")]`
	`151`	`+ result in [this.getArg(0), this.getArgByName("ciphertext"), this.getArg(1), this.getArgByName("mac_tag")]`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`