C#: remove support for legacy syntax

asgerf · asgerf · commit 0af9e8aa58f6 · 2022-02-21T08:16:55.000+01:00
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/AccessPathSyntax.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/AccessPathSyntax.qll
@@ -52,23 +52,6 @@ class AccessPath extends string instanceof AccessPath::Range {
   AccessPathToken getLastToken(int n) { result = getToken(getNumToken() - 1 - n) }
 }
 
-/**
- * An access path that uses `A of B` syntax, which should now be written as `B.A`.
- *
- * This is a compatibility layer to help test at checkpoints during transition to the new syntax.
- */
-private class LegacyAccessPath extends AccessPath {
-  LegacyAccessPath() { this.matches("% of %") }
-
-  private string getRawSplit(int n) { result = this.splitAt(" of ", n) }
-
-  private int getNumRawSplits() { result = strictcount(int n | exists(getRawSplit(n))) }
-
-  override string getRawToken(int n) { result = getRawSplit(getNumRawSplits() - n - 1) }
-
-  override predicate hasSyntaxError() { none() }
-}
-
 /**
  * An access part token such as `Argument[1]` or `ReturnValue`, appearing in one or more access paths.
  */
