Merge pull request #829 from geoffw0/deprecate-fpv

jbj · web-flow · commit 0dad04bd7ec8 · 2019-01-28T08:47:49.000+01:00
CPP: Deprecate FunctionPointerVariable and FunctionPointerMemberVariable
diff --git a/cpp/ql/src/semmle/code/cpp/Variable.qll b/cpp/ql/src/semmle/code/cpp/Variable.qll
@@ -377,17 +377,21 @@ class MemberVariable extends Variable, @membervariable {
 
 /**
  * A C/C++ function pointer variable.
+ *
+ * DEPRECATED: use `Variable.getType() instanceof FunctionPointerType` instead. 
  */
-class FunctionPointerVariable extends Variable {
+deprecated class FunctionPointerVariable extends Variable {
   FunctionPointerVariable() {
     this.getType() instanceof FunctionPointerType
   }
 }
 
 /**
  * A C/C++ function pointer member variable.
+ *
+ * DEPRECATED: use `MemberVariable.getType() instanceof FunctionPointerType` instead.
  */
-class FunctionPointerMemberVariable extends MemberVariable {
+deprecated class FunctionPointerMemberVariable extends MemberVariable {
   FunctionPointerMemberVariable() {
     this instanceof FunctionPointerVariable
   }
