CPP: Add a test of LimitedScopeFile.

geoffw0 · geoffw0 · commit 0e5d23e78bb3 · 2018-11-16T22:37:30.000Z
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-3/Rule 13/LimitedScopeFile/LimitedScopeFile.expected b/cpp/ql/test/query-tests/JPL_C/LOC-3/Rule 13/LimitedScopeFile/LimitedScopeFile.expected
@@ -0,0 +1,2 @@
+| file1.c:3:5:3:14 | globalInt1 | The global variable globalInt1 is not accessed outside of file1.c and could be made static. |
+| file1.c:5:5:5:14 | globalInt3 | The global variable globalInt3 is not accessed outside of file1.c and could be made static. |
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-3/Rule 13/LimitedScopeFile/LimitedScopeFile.qlref b/cpp/ql/test/query-tests/JPL_C/LOC-3/Rule 13/LimitedScopeFile/LimitedScopeFile.qlref
@@ -0,0 +1 @@
+JPL_C/LOC-3/Rule 13/LimitedScopeFile.ql
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-3/Rule 13/LimitedScopeFile/file1.c b/cpp/ql/test/query-tests/JPL_C/LOC-3/Rule 13/LimitedScopeFile/file1.c
@@ -0,0 +1,25 @@
+// file1.c
+
+int globalInt1; // BAD [only accessed in this file]
+int globalInt2; // GOOD [accessed in file1.c and file2.c]
+int globalInt3; // GOOD [referenced in file1.h] [FALSE POSITIVE]
+int globalInt4; // GOOD [only accessed in one function, should be function scope instead]
+int globalInt5; // GOOD [not accessed]
+
+static int staticInt1; // GOOD [static]
+
+void file1Func1()
+{
+	globalInt1++;
+	globalInt2++;
+	globalInt3++;
+	globalInt4++;
+	staticInt1++;
+}
+
+void file1Func2()
+{
+	globalInt1++;
+	globalInt3++;
+	staticInt1++;
+}
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-3/Rule 13/LimitedScopeFile/file2.c b/cpp/ql/test/query-tests/JPL_C/LOC-3/Rule 13/LimitedScopeFile/file2.c
@@ -0,0 +1,10 @@
+// file2.c
+
+#include "file1.h"
+
+extern int globalInt2;
+
+void file2Func()
+{
+	globalInt2++;
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+\| file1.c:3:5:3:14 \| globalInt1 \| The global variable globalInt1 is not accessed outside of file1.c and could be made static. \|`
	`2`	`+\| file1.c:5:5:5:14 \| globalInt3 \| The global variable globalInt3 is not accessed outside of file1.c and could be made static. \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+JPL_C/LOC-3/Rule 13/LimitedScopeFile.ql`