Python: small start on global flow

yoff · yoff · commit 0f77403f0e33 · 2020-06-16T15:36:03.000+02:00
need to actually have `OutNode`s
diff --git a/python/ql/src/semmle/code/python/dataflow/internal/DataFlowPrivate.qll b/python/ql/src/semmle/code/python/dataflow/internal/DataFlowPrivate.qll
@@ -9,7 +9,7 @@ private import DataFlowPublic
 // Nodes
 //--------
 
-class DataFlowCall extends Call {
+class DataFlowCall extends CallNode {
   /** Gets the enclosing callable of this call. */
   abstract DataFlowCallable getEnclosingCallable();
 }
@@ -103,17 +103,26 @@ predicate simpleLocalFlowStep(Node nodeFrom, Node nodeTo) {
 // Global flow
 //--------
 
-class DataFlowCallable = FunctionValue;
+import semmle.python.pointsto.CallGraph
+
+class DataFlowCallable = FunctionObject;
 
 /** Gets a viable run-time target for the call `call`. */
-DataFlowCallable viableCallable(DataFlowCall call) { none() }
+DataFlowCallable viableCallable(DataFlowCall call) {
+  exists(FunctionInvocation i |
+    call = i.getCall() and
+    result = i.getFunction())
+}
 
 /**
  * Gets a node that can read the value returned from `call` with return kind
  * `kind`.
  */
 OutNode getAnOutNode(DataFlowCall call, ReturnKind kind) { call = result.getCall(kind) }
 
+// Extend OutNode here
+// Consider whether to use AST nodes rather than CFG nodes 
+
 //--------
 // Type pruning
 //--------
