C++: Test ?: support in UsingStrcpyAsBoolean.ql

jbj · jbj · commit 0f88a4b31226 · 2019-01-10T08:35:54.000+01:00
This test shows that the query only supports the ternary operator in
C++, not C.
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/UsingStrcpyAsBoolean.expected b/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/UsingStrcpyAsBoolean.expected
@@ -24,6 +24,7 @@
 | test.cpp:127:9:127:37 | ! ... | Return value of strncpy used in a logical operation. |
 | test.cpp:131:14:131:20 | call to strncpy | Return value of strncpy used as Boolean. |
 | test.cpp:133:19:133:47 | ! ... | Return value of strncpy used in a logical operation. |
+| test.cpp:134:14:134:19 | call to strcpy | Return value of strcpy used as Boolean. |
 | test.cpp:135:14:135:40 | ... && ... | Return value of strcpy used in a logical operation. |
 | test.cpp:137:14:137:40 | ... == ... | Return value of strcpy used in a logical operation. |
 | test.cpp:139:14:139:40 | ... != ... | Return value of strcpy used in a logical operation. |
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/test.c b/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/test.c
@@ -56,7 +56,7 @@ void PositiveCases()
     }
 
     result = !strncpy(szbuf1, "test", 100); // Bug
-
+    result = strcpy(szbuf1, "test") ? 1 : 0; // Bug [NOT DETECTED]
     result = strcpy(szbuf1, "test") && 1; // Bug
 
     result = strcpy(szbuf1, "test") == 0; // Bug
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/test.cpp b/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean/test.cpp
@@ -131,7 +131,7 @@ void PositiveCases()
     bool b = strncpy(szbuf1, "test", 100); // Bug
 
     bool result = !strncpy(szbuf1, "test", 100); // Bug
-
+    result = strcpy(szbuf1, "test") ? 1 : 0; // Bug
     result = strcpy(szbuf1, "test") && 1; // Bug
 
     result = strcpy(szbuf1, "test") == 0; // Bug

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ void PositiveCases()`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`result = !strncpy(szbuf1, "test", 100); // Bug`
`59`		`-`
	`59`	`+ result = strcpy(szbuf1, "test") ? 1 : 0; // Bug [NOT DETECTED]`
`60`	`60`	`result = strcpy(szbuf1, "test") && 1; // Bug`
`61`	`61`
`62`	`62`	`result = strcpy(szbuf1, "test") == 0; // Bug`