Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 0fa06e5

Browse files
semmle-qlcisemmle-qlci
authored
Merge pull request #1180 from asger-semmle/tainted-path-squashed
Approved by xiemaisi
2 parents b17eb5c + be51736 commit 0fa06e5

17 files changed

Lines changed: 5018 additions & 215 deletions

File tree

‎change-notes/1.21/analysis-javascript.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
| Useless assignment to property | Fewer false-positive results | This rule now ignore reads of additional getters. |
4646
| Unreachable statement | Unreachable throws no longer give an alert | This ignores unreachable throws, as they could be intentional (for example, to placate the TS compiler). |
4747
| Incorrect suffix check | Fewer false-positive results | This rule now recognizes valid checks in more cases. |
48+
| Tainted path | More results and fewer false-positive results | This rule now analyses path manipulation code more precisely. |
4849

4950
## Changes to QL libraries
5051

javascript/ql/src/Security/Summaries/AllConfigurations.qll renamed to javascript/ql/src/Security/Summaries/Configurations.qll

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,10 @@ import semmle.javascript.security.dataflow.CommandInjection
1212
import semmle.javascript.security.dataflow.DomBasedXss as DomBasedXss
1313
import semmle.javascript.security.dataflow.NosqlInjection
1414
import semmle.javascript.security.dataflow.ReflectedXss as ReflectedXss
15-
import semmle.javascript.security.dataflow.RegExpInjection
16-
import semmle.javascript.security.dataflow.RemotePropertyInjection
1715
import semmle.javascript.security.dataflow.ServerSideUrlRedirect
1816
import semmle.javascript.security.dataflow.SqlInjection
19-
import semmle.javascript.security.dataflow.StackTraceExposure
2017
import semmle.javascript.security.dataflow.StoredXss as StoredXss
21-
import semmle.javascript.security.dataflow.TaintedFormatString
2218
import semmle.javascript.security.dataflow.TaintedPath
2319
import semmle.javascript.security.dataflow.UnsafeDeserialization
2420
import semmle.javascript.security.dataflow.XmlBomb
25-
import semmle.javascript.security.dataflow.XpathInjection
2621
import semmle.javascript.security.dataflow.Xxe

‎javascript/ql/src/Security/Summaries/ExtractFlowStepSummaries.ql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* @id js/step-summary-extraction
1010
*/
1111

12-
import AllConfigurations
12+
import Configurations
1313
import PortalExitSource
1414
import PortalEntrySink
1515

‎javascript/ql/src/Security/Summaries/ExtractSinkSummaries.ql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @id js/sink-summary-extraction
88
*/
99

10-
import AllConfigurations
10+
import Configurations
1111
import PortalExitSource
1212
import SinkFromAnnotation
1313

‎javascript/ql/src/Security/Summaries/ExtractSourceSummaries.ql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @id js/source-summary-extraction
88
*/
99

10-
import AllConfigurations
10+
import Configurations
1111
import PortalEntrySink
1212
import SourceFromAnnotation
1313

‎javascript/ql/src/semmle/javascript/dataflow/TaintTracking.qll‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,10 +242,10 @@ module TaintTracking {
242242
/**
243243
* A taint propagating data flow edge through persistent storage.
244244
*/
245-
private class StorageTaintStep extends AdditionalTaintStep {
245+
class PersistentStorageTaintStep extends AdditionalTaintStep {
246246
PersistentReadAccess read;
247247

248-
StorageTaintStep() { this = read }
248+
PersistentStorageTaintStep() { this = read }
249249

250250
override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
251251
pred = read.getAWrite().getValue() and

0 commit comments

Comments
 (0)