C#: ZipSlip - remove ZipSlip prefix from TaintTracking class name.

lcartey · lcartey · commit 112d104005b5 · 2018-08-20T16:18:13.000+01:00
diff --git a/csharp/ql/src/Security Features/CWE-022/ZipSlip.ql b/csharp/ql/src/Security Features/CWE-022/ZipSlip.ql
@@ -12,6 +12,6 @@
 import csharp
 import semmle.code.csharp.security.dataflow.ZipSlip::ZipSlip
 
-from ZipSlipTaintTrackingConfiguration zipTaintTracking, DataFlow::Node source, DataFlow::Node sink
+from TaintTrackingConfiguration zipTaintTracking, DataFlow::Node source, DataFlow::Node sink
 where zipTaintTracking.hasFlow(source, sink)
 select sink, "Make sure to sanitize relative archive item path before creating path for file extraction if the source of $@ is untrusted", source, "zip archive"
diff --git a/csharp/ql/src/semmle/code/csharp/security/dataflow/ZipSlip.qll b/csharp/ql/src/semmle/code/csharp/security/dataflow/ZipSlip.qll
@@ -21,8 +21,8 @@ module ZipSlip {
   abstract class Sanitizer extends DataFlow::ExprNode { }
 
   /** A taint tracking configuration for ZipSlip */
-  class ZipSlipTaintTrackingConfiguration extends TaintTracking::Configuration {
-    ZipSlipTaintTrackingConfiguration() {
+  class TaintTrackingConfiguration extends TaintTracking::Configuration {
+    TaintTrackingConfiguration() {
       this = "ZipSlipTaintTracking"
     }
 

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,8 @@ module ZipSlip {`
`21`	`21`	`abstract class Sanitizer extends DataFlow::ExprNode { }`
`22`	`22`
`23`	`23`	`/** A taint tracking configuration for ZipSlip */`
`24`		`- class ZipSlipTaintTrackingConfiguration extends TaintTracking::Configuration {`
`25`		`- ZipSlipTaintTrackingConfiguration() {`
	`24`	`+ class TaintTrackingConfiguration extends TaintTracking::Configuration {`
	`25`	`+ TaintTrackingConfiguration() {`
`26`	`26`	`this = "ZipSlipTaintTracking"`
`27`	`27`	`}`
`28`	`28`