Javascript: Autoformat qls

aschackmull · aschackmull · commit 1182fca66529 · 2019-02-12T14:38:42.000+01:00
diff --git a/javascript/ql/src/AngularJS/IncompatibleService.ql b/javascript/ql/src/AngularJS/IncompatibleService.ql
@@ -134,9 +134,7 @@ where
       isCompatibleRequestedService(request, compatibleKind) and
       not isWildcardKind(compatibleKind)
     |
-      "'" + compatibleKind + "'", ", "
-      order by
-        compatibleKind
+      "'" + compatibleKind + "'", ", " order by compatibleKind
     ).regexpReplaceAll(",(?=[^,]+$)", " or") and
   (
     isServiceDirectiveOrFilterFunction(request) and
diff --git a/javascript/ql/src/Declarations/UnstableCyclicImport.ql b/javascript/ql/src/Declarations/UnstableCyclicImport.ql
@@ -137,9 +137,7 @@ string pathToModule(Module source, Module destination, int steps) {
           isImportedAtRuntime(source, mod) and
           numberOfStepsToModule(mod, destination, steps - 1)
         |
-          mod
-          order by
-            mod.getName()
+          mod order by mod.getName()
         ) and
       result = repr(getARuntimeImport(source, next)) + " => " +
           pathToModule(next, destination, steps - 1)
diff --git a/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql b/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql
@@ -18,8 +18,8 @@ private predicate isBoundInMethod(MethodDeclaration method) {
     bindingMethod.getDeclaringClass() = method.getDeclaringClass() and
     not bindingMethod.isStatic() and
     thiz.getBinder().getAstNode() = bindingMethod.getBody()
-    |
-    exists (DataFlow::MethodCallNode bind, DataFlow::PropWrite w |
+  |
+    exists(DataFlow::MethodCallNode bind, DataFlow::PropWrite w |
       // this[x] = <expr>.bind(...)
       w = thiz.getAPropertyWrite() and
       not exists(w.getPropertyName()) and
diff --git a/javascript/ql/src/LanguageFeatures/InconsistentNew.ql b/javascript/ql/src/LanguageFeatures/InconsistentNew.ql
@@ -38,9 +38,7 @@ Function getALikelyCallee(DataFlow::InvokeNode cs, boolean isNew) {
   result = min(Function callee, int imprecision |
       callee = cs.getACallee(imprecision)
     |
-      callee
-      order by
-        imprecision
+      callee order by imprecision
     ) and
   not cs.isUncertain() and
   not whitelistedCall(cs) and
@@ -89,9 +87,7 @@ DataFlow::InvokeNode getFirstInvocation(Function f, boolean isNew) {
   result = min(DataFlow::InvokeNode invk, string path, int line, int col |
       f = getALikelyCallee(invk, isNew) and invk.hasLocationInfo(path, line, col, _, _)
     |
-      invk
-      order by
-        path, line, col
+      invk order by path, line, col
     )
 }
 
diff --git a/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql b/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql
@@ -21,9 +21,7 @@ predicate constantInCharacterClass(RegExpCharacterClass recc, int i, RegExpConst
   cc = rank[i](RegExpConstant cc2, int j |
       cc2 = recc.getChild(j) and cc2.isCharacter() and cc2.getValue() = val
     |
-      cc2
-      order by
-        j
+      cc2 order by j
     )
 }
 
diff --git a/javascript/ql/src/RegExp/IdentityReplacement.ql b/javascript/ql/src/RegExp/IdentityReplacement.ql
@@ -59,9 +59,7 @@ predicate regExpMatchesString(RegExpTerm t, string s) {
     s = concat(int i, RegExpTerm child |
         child = seq.getChild(i)
       |
-        any(string subs | regExpMatchesString(child, subs))
-        order by
-          i
+        any(string subs | regExpMatchesString(child, subs)) order by i
       )
   )
 }
diff --git a/javascript/ql/src/Security/CWE-116/DoubleEscaping.ql b/javascript/ql/src/Security/CWE-116/DoubleEscaping.ql
@@ -36,9 +36,7 @@ string getStringValue(RegExpLiteral rl) {
     result = strictconcat(RegExpTerm ch, int i |
         ch = root.(RegExpSequence).getChild(i)
       |
-        ch.(RegExpConstant).getValue()
-        order by
-          i
+        ch.(RegExpConstant).getValue() order by i
       )
   )
 }
diff --git a/javascript/ql/src/Statements/ImplicitReturn.ql b/javascript/ql/src/Statements/ImplicitReturn.ql
@@ -26,16 +26,16 @@ predicate isThrowOrReturn(Stmt s) {
 /**
  * A `return` statement with an operand (that is, not just `return;`).
  */
-class ValueReturn extends ReturnStmt { ValueReturn() { exists(getExpr()) } }
+class ValueReturn extends ReturnStmt {
+  ValueReturn() { exists(getExpr()) }
+}
 
 /** Gets the lexically first explicit return statement in function `f`. */
 ValueReturn getFirstExplicitReturn(Function f) {
   result = min(ValueReturn ret |
       ret.getContainer() = f
     |
-      ret
-      order by
-        ret.getLocation().getStartLine(), ret.getLocation().getStartColumn()
+      ret order by ret.getLocation().getStartLine(), ret.getLocation().getStartColumn()
     )
 }
 
diff --git a/javascript/ql/src/Statements/UselessConditional.ql b/javascript/ql/src/Statements/UselessConditional.ql
@@ -81,7 +81,7 @@ predicate isConstantBooleanReturnValue(Expr e) {
           ssa.getVariable().getAUse() = e
         )
       )
-      |
+    |
       ret.(BooleanLiteral).getValue() = b
     )
   )
diff --git a/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql b/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql
@@ -12,8 +12,10 @@
 import javascript
 
 from Vue::Instance instance, DataFlow::Node def, DataFlow::FunctionNode arrow, ThisExpr dis
-where instance.getABoundFunction() = def and
-      arrow.flowsTo(def) and
-      arrow.asExpr() instanceof ArrowFunctionExpr and
-      arrow.asExpr() = dis.getEnclosingFunction()
-select def, "The $@ of this $@ it will not be bound to the Vue instance.", dis, "`this` variable", arrow, "arrow function"
+where
+  instance.getABoundFunction() = def and
+  arrow.flowsTo(def) and
+  arrow.asExpr() instanceof ArrowFunctionExpr and
+  arrow.asExpr() = dis.getEnclosingFunction()
+select def, "The $@ of this $@ it will not be bound to the Vue instance.", dis, "`this` variable",
+  arrow, "arrow function"
diff --git a/javascript/ql/test/library-tests/HTML/HtmlScript/ScriptElement_getScript.ql b/javascript/ql/test/library-tests/HTML/HtmlScript/ScriptElement_getScript.ql
@@ -1,5 +1,4 @@
 import javascript
 
-
 from HTML::ScriptElement e
-select e, e.getScript()
+select e, e.getScript()
diff --git a/javascript/ql/test/library-tests/TypeScript/LocalTypeResolution/CheckResolution.ql b/javascript/ql/test/library-tests/TypeScript/LocalTypeResolution/CheckResolution.ql
@@ -1,6 +1,8 @@
 import javascript
 
-abstract class Violation extends ASTNode { abstract string reason(); }
+abstract class Violation extends ASTNode {
+  abstract string reason();
+}
 
 /**
  * Holds for tuples of form `[X, "name1"]` where `X` is a simple type access
diff --git a/javascript/ql/test/library-tests/TypeScript/Tokens/PrettyPrintTokens.ql b/javascript/ql/test/library-tests/TypeScript/Tokens/PrettyPrintTokens.ql
@@ -10,9 +10,7 @@ string getTokenStringAtLine(File file, int line) {
   result = concat(Token tok |
       tok = getATokenAtLine(file, line)
     |
-      tok.toString().replaceAll(" ", "~") + " "
-      order by
-        tok.getLocation().getStartColumn()
+      tok.toString().replaceAll(" ", "~") + " " order by tok.getLocation().getStartColumn()
     )
 }
 
diff --git a/javascript/ql/test/library-tests/TypeScript/TypeAnnotations/Containers.ql b/javascript/ql/test/library-tests/TypeScript/TypeAnnotations/Containers.ql
@@ -1,6 +1,8 @@
 import javascript
 
-abstract class Violation extends ASTNode { abstract string reason(); }
+abstract class Violation extends ASTNode {
+  abstract string reason();
+}
 
 class MissingContainer extends Violation, TypeExpr {
   MissingContainer() { not exists(getContainer()) }
diff --git a/javascript/ql/test/library-tests/TypeScript/TypeAnnotations/ImportTypeExpr.ql b/javascript/ql/test/library-tests/TypeScript/TypeAnnotations/ImportTypeExpr.ql
@@ -3,7 +3,10 @@ import javascript
 string getKind(ImportTypeExpr imprt) {
   if imprt.isTypeAccess()
   then result = "type"
-  else if imprt.isNamespaceAccess() then result = "namespace" else result = "value"
+  else
+    if imprt.isNamespaceAccess()
+    then result = "namespace"
+    else result = "value"
 }
 
 from ImportTypeExpr imprt
diff --git a/javascript/ql/test/library-tests/frameworks/Vue/Instance.ql b/javascript/ql/test/library-tests/frameworks/Vue/Instance.ql
@@ -1,3 +1,3 @@
 import javascript
 
-select any(Vue::Instance i)
+select any(Vue::Instance i)
diff --git a/javascript/ql/test/library-tests/frameworks/Vue/Instance_getAPropertyValue.ql b/javascript/ql/test/library-tests/frameworks/Vue/Instance_getAPropertyValue.ql
@@ -1,4 +1,4 @@
 import javascript
 
 from Vue::Instance i, string name
-select i, name, i.getAPropertyValue(name)
+select i, name, i.getAPropertyValue(name)
diff --git a/javascript/ql/test/library-tests/frameworks/Vue/Instance_getOption.ql b/javascript/ql/test/library-tests/frameworks/Vue/Instance_getOption.ql
@@ -1,4 +1,4 @@
 import javascript
 
 from Vue::Instance i, string name
-select i, name, i.getOption(name)
+select i, name, i.getOption(name)
diff --git a/javascript/ql/test/tutorials/Introducing the JavaScript libraries/query2.ql b/javascript/ql/test/tutorials/Introducing the JavaScript libraries/query2.ql
@@ -1,6 +1,8 @@
 import javascript
 
-class CommaToken extends PunctuatorToken { CommaToken() { getValue() = "," } }
+class CommaToken extends PunctuatorToken {
+  CommaToken() { getValue() = "," }
+}
 
 from CommaToken comma
 where comma.getNextToken() instanceof CommaToken

Original file line number	Diff line number	Diff line change
`@@ -134,9 +134,7 @@ where`
`134`	`134`	`isCompatibleRequestedService(request, compatibleKind) and`
`135`	`135`	`not isWildcardKind(compatibleKind)`
`136`	`136`	`\|`
`137`		`- "'" + compatibleKind + "'", ", "`
`138`		`- order by`
`139`		`- compatibleKind`
	`137`	`+ "'" + compatibleKind + "'", ", " order by compatibleKind`
`140`	`138`	`).regexpReplaceAll(",(?=[^,]+$)", " or") and`
`141`	`139`	`(`
`142`	`140`	`isServiceDirectiveOrFilterFunction(request) and`
Original file line number	Diff line number	Diff line change
`@@ -38,9 +38,7 @@ Function getALikelyCallee(DataFlow::InvokeNode cs, boolean isNew) {`
`38`	`38`	`result = min(Function callee, int imprecision \|`
`39`	`39`	`callee = cs.getACallee(imprecision)`
`40`	`40`	`\|`
`41`		`- callee`
`42`		`- order by`
`43`		`- imprecision`
	`41`	`+ callee order by imprecision`
`44`	`42`	`) and`
`45`	`43`	`not cs.isUncertain() and`
`46`	`44`	`not whitelistedCall(cs) and`
`@@ -89,9 +87,7 @@ DataFlow::InvokeNode getFirstInvocation(Function f, boolean isNew) {`
`89`	`87`	`result = min(DataFlow::InvokeNode invk, string path, int line, int col \|`
`90`	`88`	`f = getALikelyCallee(invk, isNew) and invk.hasLocationInfo(path, line, col, _, _)`
`91`	`89`	`\|`
`92`		`- invk`
`93`		`- order by`
`94`		`- path, line, col`
	`90`	`+ invk order by path, line, col`
`95`	`91`	`)`
`96`	`92`	`}`
`97`	`93`
Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,7 @@ predicate constantInCharacterClass(RegExpCharacterClass recc, int i, RegExpConst`
`21`	`21`	`cc = rank[i](RegExpConstant cc2, int j \|`
`22`	`22`	`cc2 = recc.getChild(j) and cc2.isCharacter() and cc2.getValue() = val`
`23`	`23`	`\|`
`24`		`- cc2`
`25`		`- order by`
`26`		`- j`
	`24`	`+ cc2 order by j`
`27`	`25`	`)`
`28`	`26`	`}`
`29`	`27`
Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,7 @@ predicate regExpMatchesString(RegExpTerm t, string s) {`
`59`	`59`	`s = concat(int i, RegExpTerm child \|`
`60`	`60`	`child = seq.getChild(i)`
`61`	`61`	`\|`
`62`		`- any(string subs \| regExpMatchesString(child, subs))`
`63`		`- order by`
`64`		`- i`
	`62`	`+ any(string subs \| regExpMatchesString(child, subs)) order by i`
`65`	`63`	`)`
`66`	`64`	`)`
`67`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,9 +36,7 @@ string getStringValue(RegExpLiteral rl) {`
`36`	`36`	`result = strictconcat(RegExpTerm ch, int i \|`
`37`	`37`	`ch = root.(RegExpSequence).getChild(i)`
`38`	`38`	`\|`
`39`		`- ch.(RegExpConstant).getValue()`
`40`		`- order by`
`41`		`- i`
	`39`	`+ ch.(RegExpConstant).getValue() order by i`
`42`	`40`	`)`
`43`	`41`	`)`
`44`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,16 +26,16 @@ predicate isThrowOrReturn(Stmt s) {`
`26`	`26`	`/**`
`27`	`27`	* A `return` statement with an operand (that is, not just `return;`).
`28`	`28`	`*/`
`29`		`-class ValueReturn extends ReturnStmt { ValueReturn() { exists(getExpr()) } }`
	`29`	`+class ValueReturn extends ReturnStmt {`
	`30`	`+ ValueReturn() { exists(getExpr()) }`
	`31`	`+}`
`30`	`32`
`31`	`33`	/** Gets the lexically first explicit return statement in function `f`. */
`32`	`34`	`ValueReturn getFirstExplicitReturn(Function f) {`
`33`	`35`	`result = min(ValueReturn ret \|`
`34`	`36`	`ret.getContainer() = f`
`35`	`37`	`\|`
`36`		`- ret`
`37`		`- order by`
`38`		`- ret.getLocation().getStartLine(), ret.getLocation().getStartColumn()`
	`38`	`+ ret order by ret.getLocation().getStartLine(), ret.getLocation().getStartColumn()`
`39`	`39`	`)`
`40`	`40`	`}`
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ predicate isConstantBooleanReturnValue(Expr e) {`
`81`	`81`	`ssa.getVariable().getAUse() = e`
`82`	`82`	`)`
`83`	`83`	`)`
`84`		`- \|`
	`84`	`+ \|`
`85`	`85`	`ret.(BooleanLiteral).getValue() = b`
`86`	`86`	`)`
`87`	`87`	`)`