Allow - character in Go package names

smowton · smowton · commit 11b457d5bf6e · 2023-04-12T14:19:00.000+01:00
diff --git a/go/ql/lib/semmle/go/dataflow/ExternalFlow.qll b/go/ql/lib/semmle/go/dataflow/ExternalFlow.qll
@@ -206,7 +206,7 @@ module ModelValidation {
       or
       summaryModel(package, type, _, name, signature, ext, _, _, _, provenance) and pred = "summary"
     |
-      not package.regexpMatch("[a-zA-Z0-9_\\./]*") and
+      not package.regexpMatch("[a-zA-Z0-9_\\./-]*") and
       result = "Dubious package \"" + package + "\" in " + pred + " model."
       or
       not type.regexpMatch("[a-zA-Z0-9_\\$<>]*") and

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ module ModelValidation {`
`206`	`206`	`or`
`207`	`207`	`summaryModel(package, type, _, name, signature, ext, _, _, _, provenance) and pred = "summary"`
`208`	`208`	`\|`
`209`		`- not package.regexpMatch("[a-zA-Z0-9_\\./]*") and`
	`209`	`+ not package.regexpMatch("[a-zA-Z0-9_\\./-]*") and`
`210`	`210`	`result = "Dubious package \"" + package + "\" in " + pred + " model."`
`211`	`211`	`or`
`212`	`212`	`not type.regexpMatch("[a-zA-Z0-9_\\$<>]*") and`