C++: delete some FIXMEs that turned out fine

Robert Marsh · Robert Marsh · commit 128bc99f90b8 · 2024-02-13T15:34:36.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedInitialization.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedInitialization.qll
@@ -1067,7 +1067,7 @@ class TranslatedConstructorBareInit extends TranslatedElement, TTranslatedConstr
     result = this.getParent().getChildSuccessor(this, kind)
   }
 
-  override Instruction getALastInstructionInternal() { none() } // FIXME: does this need to be filled in?
+  override Instruction getALastInstructionInternal() { none() }
 
   override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) {
     none()
diff --git a/cpp/ql/lib/semmle/code/cpp/models/implementations/SmartPointer.qll b/cpp/ql/lib/semmle/code/cpp/models/implementations/SmartPointer.qll
@@ -181,7 +181,6 @@ private class SmartPtrDestructor extends Destructor, SideEffectFunction, AliasFu
    * Gets the destructor associated with the base type of this smart pointer.
    */
   private Destructor getBaseTypeDestructor() {
-    // TODO: Check if this is join ordered correctly.
     result.getDeclaringType() = declaringType.getBaseType()
   }
 
@@ -222,4 +221,4 @@ private class SmartPtrDestructor extends Destructor, SideEffectFunction, AliasFu
     // A destructor call does not have a return value
     none()
   }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -1067,7 +1067,7 @@ class TranslatedConstructorBareInit extends TranslatedElement, TTranslatedConstr`
`1067`	`1067`	`result = this.getParent().getChildSuccessor(this, kind)`
`1068`	`1068`	`}`
`1069`	`1069`
`1070`		`- override Instruction getALastInstructionInternal() { none() } // FIXME: does this need to be filled in?`
	`1070`	`+ override Instruction getALastInstructionInternal() { none() }`
`1071`	`1071`
`1072`	`1072`	`override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) {`
`1073`	`1073`	`none()`
Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,6 @@ private class SmartPtrDestructor extends Destructor, SideEffectFunction, AliasFu`
`181`	`181`	`* Gets the destructor associated with the base type of this smart pointer.`
`182`	`182`	`*/`
`183`	`183`	`private Destructor getBaseTypeDestructor() {`
`184`		`- // TODO: Check if this is join ordered correctly.`
`185`	`184`	`result.getDeclaringType() = declaringType.getBaseType()`
`186`	`185`	`}`
`187`	`186`
`@@ -222,4 +221,4 @@ private class SmartPtrDestructor extends Destructor, SideEffectFunction, AliasFu`
`222`	`221`	`// A destructor call does not have a return value`
`223`	`222`	`none()`
`224`	`223`	`}`
`225`		`-}`
	`224`	`+}`