Apply suggestions from code review

yoff · tausbn · web-flow · commit 1535ce1f5d1f · 2020-11-02T18:26:37.000+01:00
Co-authored-by: Taus &lt;tausbn@github.com&gt;
diff --git a/python/ql/src/experimental/semmle/python/frameworks/PEP249.qll b/python/ql/src/experimental/semmle/python/frameworks/PEP249.qll
@@ -35,29 +35,29 @@ module Connection {
    * calls, or a special parameter that will be set when functions are called by external
    * libraries.
    *
-   * Use `Conection::instance()` predicate to get references to instances of `db.Conection`.
+   * Use `Connection::instance()` predicate to get references to instances of `db.Connection`.
    *
    * Extend this class if the module implementing PEP 249 offers more direct ways to obtain
    * a connection than going through `connect`.
    */
   abstract class InstanceSource extends DataFlow::Node { }
 
-  /** A direct instantiation of `db.Conection`. */
+  /** A direct instantiation of `db.Connection`. */
   private class ClassInstantiation extends InstanceSource, DataFlow::CfgNode {
     override CallNode node;
 
     ClassInstantiation() { node.getFunction() = connect().asCfgNode() }
   }
 
-  /** Gets a reference to an instance of `db.Conection`. */
+  /** Gets a reference to an instance of `db.Connection`. */
   private DataFlow::Node instance(DataFlow::TypeTracker t) {
     t.start() and
     result instanceof InstanceSource
     or
     exists(DataFlow::TypeTracker t2 | result = instance(t2).track(t2, t))
   }
 
-  /** Gets a reference to an instance of `db.Conection`. */
+  /** Gets a reference to an instance of `db.Connection`. */
   DataFlow::Node instance() { result = instance(DataFlow::TypeTracker::end()) }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -35,29 +35,29 @@ module Connection {`
`35`	`35`	`* calls, or a special parameter that will be set when functions are called by external`
`36`	`36`	`* libraries.`
`37`	`37`	`*`
`38`		- * Use `Conection::instance()` predicate to get references to instances of `db.Conection`.
	`38`	+ * Use `Connection::instance()` predicate to get references to instances of `db.Connection`.
`39`	`39`	`*`
`40`	`40`	`* Extend this class if the module implementing PEP 249 offers more direct ways to obtain`
`41`	`41`	* a connection than going through `connect`.
`42`	`42`	`*/`
`43`	`43`	`abstract class InstanceSource extends DataFlow::Node { }`
`44`	`44`
`45`		- /** A direct instantiation of `db.Conection`. */
	`45`	+ /** A direct instantiation of `db.Connection`. */
`46`	`46`	`private class ClassInstantiation extends InstanceSource, DataFlow::CfgNode {`
`47`	`47`	`override CallNode node;`
`48`	`48`
`49`	`49`	`ClassInstantiation() { node.getFunction() = connect().asCfgNode() }`
`50`	`50`	`}`
`51`	`51`
`52`		- /** Gets a reference to an instance of `db.Conection`. */
	`52`	+ /** Gets a reference to an instance of `db.Connection`. */
`53`	`53`	`private DataFlow::Node instance(DataFlow::TypeTracker t) {`
`54`	`54`	`t.start() and`
`55`	`55`	`result instanceof InstanceSource`
`56`	`56`	`or`
`57`	`57`	`exists(DataFlow::TypeTracker t2 \| result = instance(t2).track(t2, t))`
`58`	`58`	`}`
`59`	`59`
`60`		- /** Gets a reference to an instance of `db.Conection`. */
	`60`	+ /** Gets a reference to an instance of `db.Connection`. */
`61`	`61`	`DataFlow::Node instance() { result = instance(DataFlow::TypeTracker::end()) }`
`62`	`62`	`}`
`63`	`63`