JS: Add test for SourceNode not depending on flowsTo

asgerf · asgerf · commit 171b131eb168 · 2020-04-08T10:23:47.000+01:00
diff --git a/javascript/ql/test/library-tests/RecursionPrevention/SourceNodeFlowsTo.expected b/javascript/ql/test/library-tests/RecursionPrevention/SourceNodeFlowsTo.expected
@@ -0,0 +1 @@
+| Success |
diff --git a/javascript/ql/test/library-tests/RecursionPrevention/SourceNodeFlowsTo.ql b/javascript/ql/test/library-tests/RecursionPrevention/SourceNodeFlowsTo.ql
@@ -0,0 +1,19 @@
+/**
+ * Test that fails to compile if the domain of `SourceNode` depends on `SourceNode.flowsTo` (recursively).
+ *
+ * This tests adds a negative dependency `flowsTo --!--> SourceNode`
+ * so that the undesired edge `SourceNode --> flowsTo` completes a negative cycle.
+ */
+import javascript
+
+class BadSourceNode extends DataFlow::SourceNode {
+  BadSourceNode() {
+    this.(DataFlow::PropRead).getPropertyName() = "foo"
+  }
+
+  override predicate flowsTo(DataFlow::Node node) {
+    not node instanceof DataFlow::SourceNode
+  }
+}
+
+select "Success"
diff --git a/javascript/ql/test/library-tests/RecursionPrevention/tst.js b/javascript/ql/test/library-tests/RecursionPrevention/tst.js
@@ -0,0 +1,2 @@
+// The contents of this file don't matter
+let x = 1;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+// The contents of this file don't matter`
	`2`	`+let x = 1;`