C++: sanity test for identical Chi node operands

Robert Marsh · Robert Marsh · commit 17e14348d5d5 · 2019-10-04T12:57:30.000-07:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll
@@ -120,6 +120,10 @@ module InstructionSanity {
     )
   }
 
+  query predicate duplicateChiOperand(ChiInstruction chi) {
+    chi.getTotal() = chi.getPartial()
+  }
+
   /**
    * Holds if an instruction, other than `ExitFunction`, has no successors.
    */
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll
@@ -120,6 +120,10 @@ module InstructionSanity {
     )
   }
 
+  query predicate duplicateChiOperand(ChiInstruction chi) {
+    chi.getTotal() = chi.getPartial()
+  }
+
   /**
    * Holds if an instruction, other than `ExitFunction`, has no successors.
    */
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -120,6 +120,10 @@ module InstructionSanity {
     )
   }
 
+  query predicate duplicateChiOperand(ChiInstruction chi) {
+    chi.getTotal() = chi.getPartial()
+  }
+
   /**
    * Holds if an instruction, other than `ExitFunction`, has no successors.
    */
diff --git a/cpp/ql/test/library-tests/ir/ir/aliased_ssa_sanity.expected b/cpp/ql/test/library-tests/ir/ir/aliased_ssa_sanity.expected
@@ -7,6 +7,11 @@ unexpectedOperand
 duplicateOperand
 missingPhiOperand
 missingOperandType
+duplicateChiOperand
+| ir.cpp:1035:3:1035:12 | Chi: (const lambda [] type at line 1034, col. 21)... |
+| ir.cpp:1039:3:1039:21 | Chi: (const lambda [] type at line 1038, col. 30)... |
+| ir.cpp:1043:3:1043:23 | Chi: (const lambda [] type at line 1042, col. 32)... |
+| ir.cpp:1046:3:1046:14 | Chi: (const lambda [] type at line 1045, col. 23)... |
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/cpp/ql/test/library-tests/ir/ir/raw_sanity.expected b/cpp/ql/test/library-tests/ir/ir/raw_sanity.expected
@@ -7,6 +7,7 @@ unexpectedOperand
 duplicateOperand
 missingPhiOperand
 missingOperandType
+duplicateChiOperand
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/cpp/ql/test/library-tests/ir/ir/unaliased_ssa_sanity.expected b/cpp/ql/test/library-tests/ir/ir/unaliased_ssa_sanity.expected
@@ -7,6 +7,7 @@ unexpectedOperand
 duplicateOperand
 missingPhiOperand
 missingOperandType
+duplicateChiOperand
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/cpp/ql/test/library-tests/ir/ssa/aliased_ssa_sanity.expected b/cpp/ql/test/library-tests/ir/ssa/aliased_ssa_sanity.expected
@@ -3,6 +3,12 @@ unexpectedOperand
 duplicateOperand
 missingPhiOperand
 missingOperandType
+duplicateChiOperand
+| ssa.cpp:220:19:220:20 | Chi: call to Constructible |
+| ssa.cpp:221:3:221:3 | Chi: c |
+| ssa.cpp:222:3:222:3 | Chi: c |
+| ssa.cpp:223:21:223:37 | Chi: call to Constructible |
+| ssa.cpp:224:3:224:4 | Chi: c2 |
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/cpp/ql/test/library-tests/ir/ssa/unaliased_ssa_sanity.expected b/cpp/ql/test/library-tests/ir/ssa/unaliased_ssa_sanity.expected
@@ -3,6 +3,7 @@ unexpectedOperand
 duplicateOperand
 missingPhiOperand
 missingOperandType
+duplicateChiOperand
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll
@@ -120,6 +120,10 @@ module InstructionSanity {
     )
   }
 
+  query predicate duplicateChiOperand(ChiInstruction chi) {
+    chi.getTotal() = chi.getPartial()
+  }
+
   /**
    * Holds if an instruction, other than `ExitFunction`, has no successors.
    */
diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -120,6 +120,10 @@ module InstructionSanity {
     )
   }
 
+  query predicate duplicateChiOperand(ChiInstruction chi) {
+    chi.getTotal() = chi.getPartial()
+  }
+
   /**
    * Holds if an instruction, other than `ExitFunction`, has no successors.
    */

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,10 @@ module InstructionSanity {`
`120`	`120`	`)`
`121`	`121`	`}`
`122`	`122`
	`123`	`+ query predicate duplicateChiOperand(ChiInstruction chi) {`
	`124`	`+ chi.getTotal() = chi.getPartial()`
	`125`	`+ }`
	`126`	`+`
`123`	`127`	`/**`
`124`	`128`	* Holds if an instruction, other than `ExitFunction`, has no successors.
`125`	`129`	`*/`