Autoformat QL

smowton · smowton · commit 18d00c111617 · 2023-04-12T14:19:03.000+01:00
diff --git a/go/ql/lib/semmle/go/frameworks/Revel.qll b/go/ql/lib/semmle/go/frameworks/Revel.qll
@@ -8,7 +8,9 @@ private import semmle.go.security.OpenUrlRedirectCustomizations
 /** Provides classes and methods modeling the Revel web framework. */
 module Revel {
   /** Gets the package name `github.com/revel/revel`. */
-  string packagePath() { result = package(["github.com/revel", "github.com/robfig"] + "/revel", "") }
+  string packagePath() {
+    result = package(["github.com/revel", "github.com/robfig"] + "/revel", "")
+  }
 
   private class ControllerParams extends UntrustedFlowSource::Range, DataFlow::FieldReadNode {
     ControllerParams() {
@@ -20,7 +22,8 @@ module Revel {
   }
 
   private class ParamsFixedSanitizer extends TaintTracking::DefaultTaintSanitizer,
-    DataFlow::FieldReadNode {
+    DataFlow::FieldReadNode
+  {
     ParamsFixedSanitizer() {
       exists(Field f |
         this.readsField(_, f) and
@@ -40,7 +43,8 @@ module Revel {
 
   /** An access to an HTTP request field whose value may be controlled by an untrusted user. */
   private class UserControlledRequestField extends UntrustedFlowSource::Range,
-    DataFlow::FieldReadNode {
+    DataFlow::FieldReadNode
+  {
     UserControlledRequestField() {
       exists(string fieldName |
         this.getField().hasQualifiedName(packagePath(), "Request", fieldName)
@@ -53,7 +57,8 @@ module Revel {
   }
 
   private class UserControlledRequestMethod extends UntrustedFlowSource::Range,
-    DataFlow::MethodCallNode {
+    DataFlow::MethodCallNode
+  {
     UserControlledRequestMethod() {
       this.getTarget()
           .hasQualifiedName(packagePath(), "Request",
diff --git a/go/ql/lib/semmle/go/security/ExternalAPIs.qll b/go/ql/lib/semmle/go/security/ExternalAPIs.qll
@@ -4,7 +4,6 @@
  */
 
 import go
-
 private import semmle.go.dataflow.FlowSummary
 private import Xss
 private import SqlInjectionCustomizations
diff --git a/go/ql/src/Security/CWE-352/ConstantOauth2State.ql b/go/ql/src/Security/CWE-352/ConstantOauth2State.ql
@@ -107,7 +107,8 @@ class PrivateUrlFlowsToAuthCodeUrlCall extends DataFlow::Configuration {
     or
     // Propagate across Sprintf and similar calls
     exists(DataFlow::CallNode cn |
-      cn.getACalleeIncludingExternals().asFunction() instanceof Fmt::AppenderOrSprinter |
+      cn.getACalleeIncludingExternals().asFunction() instanceof Fmt::AppenderOrSprinter
+    |
       pred = cn.getAnArgument() and succ = cn.getResult()
     )
   }
diff --git a/go/ql/test/library-tests/semmle/go/frameworks/ElazarlGoproxy/test.ql b/go/ql/test/library-tests/semmle/go/frameworks/ElazarlGoproxy/test.ql
@@ -70,9 +70,10 @@ class TaintFlow extends InlineExpectationsTest {
     value = "" and
     element = "" and
     exists(Config c, DataFlow::Node fromNode, DataFlow::Node toNode |
-      toNode.hasLocationInfo(location.getFile().getAbsolutePath(), location.getStartLine(),
-        location.getStartColumn(), location.getEndLine(), location.getEndColumn()) and
+      toNode
+          .hasLocationInfo(location.getFile().getAbsolutePath(), location.getStartLine(),
+            location.getStartColumn(), location.getEndLine(), location.getEndColumn()) and
       c.hasFlow(fromNode, toNode)
     )
   }
-}
+}
diff --git a/go/ql/test/library-tests/semmle/go/frameworks/SQL/QueryString.ql b/go/ql/test/library-tests/semmle/go/frameworks/SQL/QueryString.ql
@@ -36,9 +36,7 @@ class QueryString extends InlineExpectationsTest {
 class Config extends TaintTracking::Configuration {
   Config() { this = "pg-orm config" }
 
-  override predicate isSource(DataFlow::Node n) {
-    n.asExpr() instanceof StringLit
-  }
+  override predicate isSource(DataFlow::Node n) { n.asExpr() instanceof StringLit }
 
   override predicate isSink(DataFlow::Node n) {
     n = any(DataFlow::CallNode cn | cn.getTarget().getName() = "sink").getAnArgument()
@@ -54,10 +52,11 @@ class TaintFlow extends InlineExpectationsTest {
     tag = "flowfrom" and
     element = "" and
     exists(Config c, DataFlow::Node fromNode, DataFlow::Node toNode |
-      toNode.hasLocationInfo(location.getFile().getAbsolutePath(), location.getStartLine(),
-        location.getStartColumn(), location.getEndLine(), location.getEndColumn()) and
+      toNode
+          .hasLocationInfo(location.getFile().getAbsolutePath(), location.getStartLine(),
+            location.getStartColumn(), location.getEndLine(), location.getEndColumn()) and
       c.hasFlow(fromNode, toNode) and
       value = fromNode.asExpr().(StringLit).getValue()
     )
   }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,8 @@ class PrivateUrlFlowsToAuthCodeUrlCall extends DataFlow::Configuration {`
`107`	`107`	`or`
`108`	`108`	`// Propagate across Sprintf and similar calls`
`109`	`109`	`exists(DataFlow::CallNode cn \|`
`110`		`- cn.getACalleeIncludingExternals().asFunction() instanceof Fmt::AppenderOrSprinter \|`
	`110`	`+ cn.getACalleeIncludingExternals().asFunction() instanceof Fmt::AppenderOrSprinter`
	`111`	`+ \|`
`111`	`112`	`pred = cn.getAnArgument() and succ = cn.getResult()`
`112`	`113`	`)`
`113`	`114`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,9 +70,10 @@ class TaintFlow extends InlineExpectationsTest {`
`70`	`70`	`value = "" and`
`71`	`71`	`element = "" and`
`72`	`72`	`exists(Config c, DataFlow::Node fromNode, DataFlow::Node toNode \|`
`73`		`- toNode.hasLocationInfo(location.getFile().getAbsolutePath(), location.getStartLine(),`
`74`		`- location.getStartColumn(), location.getEndLine(), location.getEndColumn()) and`
	`73`	`+ toNode`
	`74`	`+ .hasLocationInfo(location.getFile().getAbsolutePath(), location.getStartLine(),`
	`75`	`+ location.getStartColumn(), location.getEndLine(), location.getEndColumn()) and`
`75`	`76`	`c.hasFlow(fromNode, toNode)`
`76`	`77`	`)`
`77`	`78`	`}`
`78`		`-}`
	`79`	`+}`