C++: Extend model to include std::forward_list::insert_after.

geoffw0 · geoffw0 · commit 1ad404c605f9 · 2020-09-03T10:52:26.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/StdContainer.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/StdContainer.qll
@@ -90,11 +90,12 @@ class StdSequenceContainerFrontBack extends TaintFunction {
 }
 
 /**
- * The standard container function `insert`.
+ * The standard container functions `insert` and `insert_after`.
  */
 class StdSequenceContainerInsert extends TaintFunction {
   StdSequenceContainerInsert() {
-    this.hasQualifiedName("std", ["vector", "deque", "list"], "insert")
+    this.hasQualifiedName("std", ["vector", "deque", "list"], "insert") or
+    this.hasQualifiedName("std", ["forward_list"], "insert_after")
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -90,11 +90,12 @@ class StdSequenceContainerFrontBack extends TaintFunction {`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`/**`
`93`		- * The standard container function `insert`.
	`93`	+ * The standard container functions `insert` and `insert_after`.
`94`	`94`	`*/`
`95`	`95`	`class StdSequenceContainerInsert extends TaintFunction {`
`96`	`96`	`StdSequenceContainerInsert() {`
`97`		`- this.hasQualifiedName("std", ["vector", "deque", "list"], "insert")`
	`97`	`+ this.hasQualifiedName("std", ["vector", "deque", "list"], "insert") or`
	`98`	`+ this.hasQualifiedName("std", ["forward_list"], "insert_after")`
`98`	`99`	`}`
`99`	`100`
`100`	`101`	`/**`