Python points-to. Fix attribute lookup for type.

markshannon · markshannon · commit 1c20336eb982 · 2019-05-13T17:24:02.000+01:00
diff --git a/python/ql/src/semmle/python/objects/Classes.qll b/python/ql/src/semmle/python/objects/Classes.qll
@@ -284,7 +284,8 @@ class TypeInternal extends ClassObjectInternal, TType {
     }
 
     override predicate lookup(string name, ObjectInternal value, CfgOrigin origin) {
-        none()
+        value = ObjectInternal::fromBuiltin(Builtin::special("type").getMember(name)) and
+        origin = CfgOrigin::unknown()
     }
 
     pragma [noinline] override predicate attributesUnknown() { any() }

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,8 @@ class TypeInternal extends ClassObjectInternal, TType {`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`override predicate lookup(string name, ObjectInternal value, CfgOrigin origin) {`
`287`		`- none()`
	`287`	`+ value = ObjectInternal::fromBuiltin(Builtin::special("type").getMember(name)) and`
	`288`	`+ origin = CfgOrigin::unknown()`
`288`	`289`	`}`
`289`	`290`
`290`	`291`	`pragma [noinline] override predicate attributesUnknown() { any() }`