Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 1c43d11

Browse files
committed
FIXME already fixed
1 parent 5e98ff4 commit 1c43d11

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

  • python/ql/src/meta/ClassHierarchy

python/ql/src/meta/ClassHierarchy/Find.ql

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,6 @@ private import semmle.python.frameworks.FastApi
1313
private import semmle.python.frameworks.Django
1414
import semmle.python.frameworks.data.internal.ApiGraphModelsExtensions as Extensions
1515

16-
// FIXME: I think the implementation below for `getAlreadyModeledClass` is wrong, since
17-
// it uses `.getASubclass*()` for flask/fastAPI (and initially also Django, I just fixed
18-
// it for django while discovering this problem). Basically, I fear that it if library
19-
// defines class A and B, where B is a subclass of A, the automated modeling might only
20-
// find B...
21-
//
22-
// I doesn't seem to be the case, which is probably why I didn't discover this, but on
23-
// top of my head I can't really tell why.
2416
class FlaskViewClasses extends FindSubclassesSpec {
2517
FlaskViewClasses() { this = "flask.View~Subclass" }
2618

0 commit comments

Comments
 (0)