fix an instance of ql/acronyms-should-be-pascal-case

erik-krogh · erik-krogh · commit 1c5d59f885d9 · 2022-04-20T18:10:53.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/DomBasedXssCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/DomBasedXssCustomizations.qll
@@ -116,10 +116,13 @@ module DomBasedXss {
   /**
    * A write to a URL which may execute JavaScript code.
    */
-  class WriteURLSink extends Sink instanceof ClientSideUrlRedirect::Sink {
-    WriteURLSink() { super.isXssSink() }
+  class WriteUrlSink extends Sink instanceof ClientSideUrlRedirect::Sink {
+    WriteUrlSink() { super.isXssSink() }
   }
 
+  /** DEPRECATED: Alias for `WriteUrlSink`. */
+  deprecated class WriteURLSink = WriteUrlSink;
+
   /**
    * An expression whose value is interpreted as HTML or CSS
    * and may be inserted into the DOM.
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/DomBasedXssQuery.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/DomBasedXssQuery.qll
@@ -25,7 +25,7 @@ deprecated class JQueryHtmlOrSelectorInjectionConfiguration = Configuration;
  */
 class HTMLSink extends DataFlow::Node instanceof Sink {
   HTMLSink() {
-    not this instanceof WriteURLSink and
+    not this instanceof WriteUrlSink and
     not this instanceof JQueryHtmlOrSelectorSink
   }
 }
@@ -61,7 +61,7 @@ class Configuration extends TaintTracking::Configuration {
     sink instanceof JQueryHtmlOrSelectorSink and
     label = [DataFlow::FlowLabel::taint(), prefixLabel()]
     or
-    sink instanceof WriteURLSink and
+    sink instanceof WriteUrlSink and
     label = prefixLabel()
   }
 
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomQuery.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomQuery.qll
@@ -46,7 +46,7 @@ class Configuration extends TaintTracking::Configuration {
     super.hasFlowPath(src, sink) and
     // filtering away readings of `src` that end in a URL sink.
     not (
-      sink.getNode() instanceof DomBasedXss::WriteURLSink and
+      sink.getNode() instanceof DomBasedXss::WriteUrlSink and
       src.getNode().(DomPropertySource).getPropertyName() = "src"
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ deprecated class JQueryHtmlOrSelectorInjectionConfiguration = Configuration;`
`25`	`25`	`*/`
`26`	`26`	`class HTMLSink extends DataFlow::Node instanceof Sink {`
`27`	`27`	`HTMLSink() {`
`28`		`- not this instanceof WriteURLSink and`
	`28`	`+ not this instanceof WriteUrlSink and`
`29`	`29`	`not this instanceof JQueryHtmlOrSelectorSink`
`30`	`30`	`}`
`31`	`31`	`}`
`@@ -61,7 +61,7 @@ class Configuration extends TaintTracking::Configuration {`
`61`	`61`	`sink instanceof JQueryHtmlOrSelectorSink and`
`62`	`62`	`label = [DataFlow::FlowLabel::taint(), prefixLabel()]`
`63`	`63`	`or`
`64`		`- sink instanceof WriteURLSink and`
	`64`	`+ sink instanceof WriteUrlSink and`
`65`	`65`	`label = prefixLabel()`
`66`	`66`	`}`
`67`	`67`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class Configuration extends TaintTracking::Configuration {`
`46`	`46`	`super.hasFlowPath(src, sink) and`
`47`	`47`	// filtering away readings of `src` that end in a URL sink.
`48`	`48`	`not (`
`49`		`- sink.getNode() instanceof DomBasedXss::WriteURLSink and`
	`49`	`+ sink.getNode() instanceof DomBasedXss::WriteUrlSink and`
`50`	`50`	`src.getNode().(DomPropertySource).getPropertyName() = "src"`
`51`	`51`	`)`
`52`	`52`	`}`