JS: improve comment syntax

esbena · esbena · commit 23d29a80db0b · 2019-11-21T13:16:40.000+01:00
diff --git a/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql b/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql
@@ -48,16 +48,16 @@ private predicate isBoundInMethod(MethodDeclaration method) {
       // exclude the binding assignments
       not thiz.getAPropertySource() = binder
     |
-      // myBindAll(this)
+      // `myBindAll(this)`
       binder.getNumArgument() = 1
       or
-      // myBindSome(this, [<name1>, <name2>])
+      // `myBindSome(this, [<name1>, <name2>])`
       exists(DataFlow::ArrayCreationNode names |
         names.flowsTo(binder.getAnArgument()) and
         names.getAnElement().mayHaveStringValue(name)
       )
       or
-      // myBindSome(this, <name1>, <name2>)
+      // `myBindSome(this, <name1>, <name2>)`
       binder.getAnArgument().mayHaveStringValue(name)
     )
   )
@@ -70,10 +70,10 @@ private predicate isBoundInMethod(MethodDeclaration method) {
     ) and
     name.regexpMatch("(?i).*(bind|bound).*")
   |
-    // @autobind
+    // `@autobind`
     decoration.(Identifier).getName() = name
     or
-    // @action.bound
+    // `@action.bound`
     decoration.(PropAccess).getPropertyName() = name
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -48,16 +48,16 @@ private predicate isBoundInMethod(MethodDeclaration method) {`
`48`	`48`	`// exclude the binding assignments`
`49`	`49`	`not thiz.getAPropertySource() = binder`
`50`	`50`	`\|`
`51`		`- // myBindAll(this)`
	`51`	+ // `myBindAll(this)`
`52`	`52`	`binder.getNumArgument() = 1`
`53`	`53`	`or`
`54`		`- // myBindSome(this, [<name1>, <name2>])`
	`54`	+ // `myBindSome(this, [<name1>, <name2>])`
`55`	`55`	`exists(DataFlow::ArrayCreationNode names \|`
`56`	`56`	`names.flowsTo(binder.getAnArgument()) and`
`57`	`57`	`names.getAnElement().mayHaveStringValue(name)`
`58`	`58`	`)`
`59`	`59`	`or`
`60`		`- // myBindSome(this, <name1>, <name2>)`
	`60`	+ // `myBindSome(this, <name1>, <name2>)`
`61`	`61`	`binder.getAnArgument().mayHaveStringValue(name)`
`62`	`62`	`)`
`63`	`63`	`)`
`@@ -70,10 +70,10 @@ private predicate isBoundInMethod(MethodDeclaration method) {`
`70`	`70`	`) and`
`71`	`71`	`name.regexpMatch("(?i).(bind\|bound).")`
`72`	`72`	`\|`
`73`		`- // @autobind`
	`73`	+ // `@autobind`
`74`	`74`	`decoration.(Identifier).getName() = name`
`75`	`75`	`or`
`76`		`- // @action.bound`
	`76`	+ // `@action.bound`
`77`	`77`	`decoration.(PropAccess).getPropertyName() = name`
`78`	`78`	`)`
`79`	`79`	`}`