Python: Fix minor problems in security examples

RasmusWL · RasmusWL · commit 27a7d09c94ab · 2020-02-03T14:35:09.000+01:00
diff --git a/python/ql/src/Security/CWE-022/examples/tainted_path.py b/python/ql/src/Security/CWE-022/examples/tainted_path.py
@@ -11,7 +11,6 @@
 
 def user_picture1(request):
     """A view that is vulnerable to malicious file access."""
-    base_path = '/server/static/images'
     filename = request.GET.get('p')
     # BAD: This could read any file on the file system
     data = open(filename, 'rb').read()
diff --git a/python/ql/src/Security/CWE-078/examples/command_injection.py b/python/ql/src/Security/CWE-078/examples/command_injection.py
@@ -20,5 +20,4 @@ def command_execution_safe(request):
     if request.method == 'POST':
         action = request.POST.get('action', '')
         #GOOD -- Use a whitelist
-        subprocess.call(["application", COMMAND[action]])
-
+        subprocess.call(["application", COMMANDS[action]])
