Add exported requirement to ContentProvider permissions test

egregius313 · egregius313 · commit 28e70497225a · 2022-10-03T10:52:42.000-04:00
diff --git a/java/ql/test/query-tests/security/CWE-276/android/incomplete_provider_permissions/ContentProviderIncompletePermissionsTest.ql b/java/ql/test/query-tests/security/CWE-276/android/incomplete_provider_permissions/ContentProviderIncompletePermissionsTest.ql
@@ -15,7 +15,8 @@ class ContentProviderIncompletePermissionsTest extends InlineExpectationsTest {
       value = ""
     |
       not provider.getFile().(AndroidManifestXmlFile).isInBuildDirectory() and
-      provider.hasIncompletePermissions()
+      provider.hasIncompletePermissions() and
+      provider.isExported()
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,8 @@ class ContentProviderIncompletePermissionsTest extends InlineExpectationsTest {`
`15`	`15`	`value = ""`
`16`	`16`	`\|`
`17`	`17`	`not provider.getFile().(AndroidManifestXmlFile).isInBuildDirectory() and`
`18`		`- provider.hasIncompletePermissions()`
	`18`	`+ provider.hasIncompletePermissions() and`
	`19`	`+ provider.isExported()`
`19`	`20`	`)`
`20`	`21`	`}`
`21`	`22`	`}`