Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 2baa748

Browse files
zlaski-semmlegeoffw0
authored andcommitted
Address further review comments.
1 parent faf4342 commit 2baa748

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

cpp/ql/src/semmle/code/cpp/Type.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1184,9 +1184,11 @@ class ArrayType extends DerivedType {
11841184
* allows vector types to be introduced using the `ext_vector_type`,
11851185
* `neon_vector_type`, and `neon_polyvector_type` attributes (all of which take
11861186
* an element count rather than a byte size).
1187+
*
1188+
* In the example below, both `v4si` and `float4` are GNU vector types:
11871189
* ```
11881190
* typedef int v4si __attribute__ (( vector_size(4*sizeof(int)) ));
1189-
* v4si v = { 1, 2, 3, 4 };
1191+
* typedef float float4 __attribute__((ext_vector_type(4)));
11901192
* ```
11911193
*/
11921194
class GNUVectorType extends DerivedType {

cpp/ql/src/semmle/code/cpp/exprs/Assignment.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ class AssignPointerSubExpr extends AssignOperation, @assignpsubexpr {
218218
* // c is no longer in scope
219219
* while (int d = x - y) { do_something_else_with(d); }
220220
* // d is no longer is scope
221-
* ```
221+
* ```
222222
*/
223223
class ConditionDeclExpr extends Expr, @condition_decl {
224224
/**

cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import semmle.code.cpp.exprs.Expr
22

33
/**
44
* A C/C++ builtin operation. This is the root QL class encompassing
5-
* built-in operationality.
5+
* built-in functionality.
66
*/
77
abstract class BuiltInOperation extends Expr {
88
override string getCanonicalQLClass() { result = "BuiltInOperation" }
@@ -83,7 +83,7 @@ class BuiltInNoOp extends BuiltInOperation, @noopexpr {
8383
deprecated class BuiltInOperationOffsetOf = BuiltInOperationBuiltInOffsetOf;
8484

8585
/**
86-
* A C/C++ `__offsetof` built-in operation (used by some implementations
86+
* A C/C++ `__builtin_offsetof` built-in operation (used by some implementations
8787
* of `offsetof`). The operation retains its semantics even in the presence
8888
* of an overloaded `operator &`). This is a GNU/Clang extension.
8989
* ```

0 commit comments

Comments
 (0)