Go: Add summary model validation on the kind column.

michaelnebel · michaelnebel · commit 2c2e09b20b52 · 2022-08-24T09:58:52.000+02:00
diff --git a/go/ql/lib/semmle/go/dataflow/CsvValidation.qll b/go/ql/lib/semmle/go/dataflow/CsvValidation.qll
@@ -36,7 +36,13 @@ private string getInvalidModelOutput() {
   )
 }
 
-private string getInvalidModelKind() { none() }
+private string getInvalidModelKind() {
+  exists(string row, string kind | summaryModel(row) |
+    kind = row.splitAt(";", 8) and
+    not kind = ["taint", "value"] and
+    result = "Invalid kind \"" + kind + "\" in summary model."
+  )
+}
 
 private string getInvalidModelSubtype() {
   exists(string pred, string row, int expect |

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,13 @@ private string getInvalidModelOutput() {`
`36`	`36`	`)`
`37`	`37`	`}`
`38`	`38`
`39`		`-private string getInvalidModelKind() { none() }`
	`39`	`+private string getInvalidModelKind() {`
	`40`	`+ exists(string row, string kind \| summaryModel(row) \|`
	`41`	`+ kind = row.splitAt(";", 8) and`
	`42`	`+ not kind = ["taint", "value"] and`
	`43`	`+ result = "Invalid kind \"" + kind + "\" in summary model."`
	`44`	`+ )`
	`45`	`+}`
`40`	`46`
`41`	`47`	`private string getInvalidModelSubtype() {`
`42`	`48`	`exists(string pred, string row, int expect \|`