Codegen: remove unneeded has_description property

redsun82 · redsun82 · commit 2d34fec0a2da · 2023-11-24T06:56:55.000+01:00
diff --git a/misc/codegen/lib/ql.py b/misc/codegen/lib/ql.py
@@ -81,10 +81,6 @@ def is_single(self):
     def is_child(self):
         return self.prev_child is not None
 
-    @property
-    def has_description(self) -> bool:
-        return bool(self.description)
-
     @property
     def is_indexed(self) -> bool:
         return self.is_repeated and not self.is_unordered
diff --git a/misc/codegen/templates/ql_class.mustache b/misc/codegen/templates/ql_class.mustache
@@ -83,11 +83,9 @@ module Generated {
 
     /**
      * {{>ql_property_doc}}     *
-    {{#has_description}}
     {{#description}}
      * {{.}}
     {{/description}}
-    {{/has_description}}
      */
     final {{type}} {{getter}}({{#is_indexed}}int index{{/is_indexed}}) {
       exists({{type}} immediate | immediate = this.get{{#is_unordered}}An{{/is_unordered}}Immediate{{singular}}({{#is_indexed}}index{{/is_indexed}}) and
@@ -98,11 +96,9 @@ module Generated {
     {{^type_is_hideable}}
     /**
      * {{>ql_property_doc}}     *
-    {{#has_description}}
     {{#description}}
      * {{.}}
     {{/description}}
-    {{/has_description}}
      */
     {{type}} {{getter}}({{#is_indexed}}int index{{/is_indexed}}) {
       {{^synth}}
diff --git a/misc/codegen/templates/ql_db.mustache b/misc/codegen/templates/ql_db.mustache
@@ -18,11 +18,9 @@ module Raw {
     {{^synth}}
     /**
      * {{>ql_property_doc}}     *
-    {{#has_description}}
     {{#description}}
      * {{.}}
     {{/description}}
-    {{/has_description}}
      */
     {{type}} {{getter}}({{#is_indexed}}int index{{/is_indexed}}) {
       {{tablename}}({{#tableparams}}{{^first}}, {{/first}}{{param}}{{/tableparams}})
diff --git a/misc/codegen/test/test_ql.py b/misc/codegen/test/test_ql.py
@@ -159,16 +159,6 @@ def test_has_doc(doc, internal, expected):
     assert stub.has_qldoc is expected
 
 
-def test_property_with_description():
-    prop = ql.Property("X", "int", description=["foo", "bar"])
-    assert prop.has_description is True
-
-
-def test_class_without_description():
-    prop = ql.Property("X", "int")
-    assert prop.has_description is False
-
-
 def test_synth_accessor_has_first_constructor_param_marked():
     params = ["a", "b", "c"]
     x = ql.SynthUnderlyingAccessor("foo", "bar", params)
