JS: Add test for empty regex

asgerf · asgerf · commit 2d534163d02d · 2020-01-07T10:10:29.000Z
diff --git a/javascript/ql/test/query-tests/RegExp/RegExpAlwaysMatches/RegExpAlwaysMatches.expected b/javascript/ql/test/query-tests/RegExp/RegExpAlwaysMatches/RegExpAlwaysMatches.expected
@@ -3,3 +3,4 @@
 | tst.js:22:11:22:34 | ^(?:https?:\|ftp:\|file:)? | This regular expression always matches when used in a test $@, as it can match an empty substring. | tst.js:22:10:22:43 | /^(?:ht ... test(x) | here |
 | tst.js:30:11:30:20 | (foo\|bar)? | This regular expression always matches when used in a test $@, as it can match an empty substring. | tst.js:30:10:30:29 | /(foo\|bar)?/.test(x) | here |
 | tst.js:34:21:34:26 | (baz)? | This regular expression always matches when used in a test $@, as it can match an empty substring. | tst.js:34:10:34:35 | /^foo\|b ... test(x) | here |
+| tst.js:86:22:86:21 |  | This regular expression always matches when used in a test $@, as it can match an empty substring. | tst.js:86:10:86:31 | new Reg ... test(x) | here |
diff --git a/javascript/ql/test/query-tests/RegExp/RegExpAlwaysMatches/tst.js b/javascript/ql/test/query-tests/RegExp/RegExpAlwaysMatches/tst.js
@@ -81,3 +81,7 @@ function wordBoundary(x) {
 function nonWordBoundary(x) {
   return /\B/.test(x); // OK - some strings don't have non-word boundaries
 }
+
+function emptyRegex(x) {
+  return new RegExp("").test(x); // NOT OK
+}

Original file line number	Diff line number	Diff line change
`@@ -81,3 +81,7 @@ function wordBoundary(x) {`
`81`	`81`	`function nonWordBoundary(x) {`
`82`	`82`	`return /\B/.test(x); // OK - some strings don't have non-word boundaries`
`83`	`83`	`}`
	`84`	`+`
	`85`	`+function emptyRegex(x) {`
	`86`	`+ return new RegExp("").test(x); // NOT OK`
	`87`	`+}`