Add method access qualifier as source

luchua-bc · smowton · commit 2ddeb0b16977 · 2020-10-23T11:57:02.000+01:00
diff --git a/java/ql/src/semmle/code/java/dataflow/FlowSources.qll b/java/ql/src/semmle/code/java/dataflow/FlowSources.qll
@@ -346,7 +346,10 @@ private class AndroidIntentExtraSource extends RemoteFlowSource {
   AndroidIntentExtraSource() {
     exists(MethodAccess ma |
       ma instanceof IntentGetExtraMethodAccess and
-      this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma
+      (
+        this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma or
+        ma.getQualifier() = this.asExpr()
+      )
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,10 @@ private class AndroidIntentExtraSource extends RemoteFlowSource {`
`346`	`346`	`AndroidIntentExtraSource() {`
`347`	`347`	`exists(MethodAccess ma \|`
`348`	`348`	`ma instanceof IntentGetExtraMethodAccess and`
`349`		`- this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma`
	`349`	`+ (`
	`350`	`+ this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma or`
	`351`	`+ ma.getQualifier() = this.asExpr()`
	`352`	`+ )`
`350`	`353`	`)`
`351`	`354`	`}`
`352`	`355`