Python: Fix minor bug in modernisation-rewrite

RasmusWL · RasmusWL · commit 31cfb1689c4b · 2020-03-09T15:49:08.000+01:00
Obviously the result module shouldn't be a package 🤦 I was confusing
myself, since I wanted to say that `Module::named("Crypto.Cipher")` should be a package :D
diff --git a/python/ql/src/semmle/python/security/Crypto.qll b/python/ql/src/semmle/python/security/Crypto.qll
@@ -16,8 +16,7 @@ abstract class WeakCryptoSink extends TaintSink {
 module Pycrypto {
 
     ModuleValue cipher(string name) {
-        result = Module::named("Crypto.Cipher").attr(name) and
-        result.isPackage()
+        result = Module::named("Crypto.Cipher").attr(name)
     }
 
     class CipherInstance extends TaintKind {

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,7 @@ abstract class WeakCryptoSink extends TaintSink {`
`16`	`16`	`module Pycrypto {`
`17`	`17`
`18`	`18`	`ModuleValue cipher(string name) {`
`19`		`- result = Module::named("Crypto.Cipher").attr(name) and`
`20`		`- result.isPackage()`
	`19`	`+ result = Module::named("Crypto.Cipher").attr(name)`
`21`	`20`	`}`
`22`	`21`
`23`	`22`	`class CipherInstance extends TaintKind {`