Apply suggestions from code review

jorgectf · RasmusWL · web-flow · commit 350440897c75 · 2021-06-28T21:02:40.000+02:00
Update `xmltodict` format and delete `ujson` modeling.

Co-authored-by: Rasmus Wriedt Larsen &lt;rasmuswriedtlarsen@gmail.com&gt;
diff --git a/python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll b/python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll
@@ -119,27 +119,5 @@ private class XmlToDictParseCall extends Decoding::Range, DataFlow::CallCfgNode
 
   override DataFlow::Node getOutput() { result = this }
 
-  override string getFormat() { result = "JSON" }
-}
-
-// ---------------------------------------------------------------------------
-// ujson
-// ---------------------------------------------------------------------------
-/** Gets a reference to the `ujson` module. */
-API::Node ujson() { result = API::moduleImport("ujson") }
-
-/**
- * A call to `ujson.loads`
- * See https://pypi.org/project/ujson/#usage
- */
-private class UltraJsonLoadsCall extends Decoding::Range, DataFlow::CallCfgNode {
-  UltraJsonLoadsCall() { this = ujson().getMember("loads").getACall() }
-
-  override predicate mayExecuteInput() { none() }
-
-  override DataFlow::Node getAnInput() { result = this.getArg(0) }
-
-  override DataFlow::Node getOutput() { result = this }
-
-  override string getFormat() { result = "JSON" }
+  override string getFormat() { result = "XML" }
 }
