C++: Add a case for global or namespace variables in 'interpretElement0'.

MathiasVP · MathiasVP · commit 3719e10ce875 · 2024-02-09T13:27:32.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll
@@ -434,6 +434,12 @@ private Element interpretElement0(
       subtypes = false and
       classWithMember = namedClass
     )
+    or
+    // Global or namespace variables
+    signature = "" and
+    type = "" and
+    subtypes = false and
+    result = any(GlobalOrNamespaceVariable v | v.hasQualifiedName(namespace, name))
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -434,6 +434,12 @@ private Element interpretElement0(`
`434`	`434`	`subtypes = false and`
`435`	`435`	`classWithMember = namedClass`
`436`	`436`	`)`
	`437`	`+ or`
	`438`	`+ // Global or namespace variables`
	`439`	`+ signature = "" and`
	`440`	`+ type = "" and`
	`441`	`+ subtypes = false and`
	`442`	`+ result = any(GlobalOrNamespaceVariable v \| v.hasQualifiedName(namespace, name))`
`437`	`443`	`)`
`438`	`444`	`}`
`439`	`445`