Python: allow CaptureArgumentNodes as multiple arguemnts

yoff · yoff · commit 38e03216f66c · 2023-12-14T10:32:29.000+01:00
These are the labmda self references. This is similar to
how `BlockParameterArgumentNode` is excluded for Ruby.

It is important that we restrict `call` in this logic.
Otherwise, we get a cartesian product and the consistency
check runs for a very long time...
diff --git a/python/ql/consistency-queries/DataFlowConsistency.ql b/python/ql/consistency-queries/DataFlowConsistency.ql
@@ -140,6 +140,9 @@ private module Input implements InputSig<PythonDataFlow> {
       arg = other.getArgument(any(ArgumentPosition p | p.isSelf())) and
       other.getNode().getScope() = f
     )
+    or
+    arg = call.getArgument(_) and
+    arg instanceof CaptureArgumentNode
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -140,6 +140,9 @@ private module Input implements InputSig<PythonDataFlow> {`
`140`	`140`	`arg = other.getArgument(any(ArgumentPosition p \| p.isSelf())) and`
`141`	`141`	`other.getNode().getScope() = f`
`142`	`142`	`)`
	`143`	`+ or`
	`144`	`+ arg = call.getArgument(_) and`
	`145`	`+ arg instanceof CaptureArgumentNode`
`143`	`146`	`}`
`144`	`147`	`}`
`145`	`148`