Update DivideByZeroUsingReturnValue.ql

ihsinme · web-flow · commit 392c948487b4 · 2022-10-05T09:27:20.000+03:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-369/DivideByZeroUsingReturnValue.ql b/cpp/ql/src/experimental/Security/CWE/CWE-369/DivideByZeroUsingReturnValue.ql
@@ -30,7 +30,7 @@ predicate mayBeReturnValue(Function fn, Expr val) {
       or
       exists(Initializer it |
         globalValueNumber(it.getExpr()) = globalValueNumber(tmpExp) and
-        it.getDeclaration().(Variable).getAnAccess().(VariableAccess).getTarget() =
+        it.getDeclaration().(Variable).getAnAccess().getTarget() =
           globalValueNumber(rs.getExpr()).getAnExpr().(VariableAccess).getTarget()
       )
     )
@@ -61,7 +61,7 @@ predicate mayBeReturnZero(Function fn) {
   fn.hasName(["getc", "atoi"])
 }
 
-/** The function returns Guard which compares the expression `bound` */
+/** Gets the Guard which compares the expression `bound` */
 pragma[inline]
 GuardCondition checkByValue(Expr bound, Expr val) {
   exists(GuardCondition gc |
@@ -178,7 +178,7 @@ predicate checkConditions2(Expr div, Expr divVal, float changeInt2) {
   )
 }
 
-/** The function returns the value of the difference or summand from the expression `src`. */
+/** Gets the value of the difference or summand from the expression `src`. */
 float getValueOperand(Expr src, Expr e1, Expr e2) {
   src.(SubExpr).hasOperands(e1, e2) and
   result = e2.getValue().toFloat()
@@ -194,7 +194,7 @@ Expr getMulDivOperand(Expr e1) {
   result = e1.(DivExpr).getLeftOperand()
 }
 
-/** Class that defines possible variants of the division expression or the search for the remainder. */
+/** The class that defines possible variants of the division expression or the search for the remainder. */
 class MyDiv extends Expr {
   MyDiv() {
     this instanceof DivExpr or

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ predicate mayBeReturnValue(Function fn, Expr val) {`
`30`	`30`	`or`
`31`	`31`	`exists(Initializer it \|`
`32`	`32`	`globalValueNumber(it.getExpr()) = globalValueNumber(tmpExp) and`
`33`		`- it.getDeclaration().(Variable).getAnAccess().(VariableAccess).getTarget() =`
	`33`	`+ it.getDeclaration().(Variable).getAnAccess().getTarget() =`
`34`	`34`	`globalValueNumber(rs.getExpr()).getAnExpr().(VariableAccess).getTarget()`
`35`	`35`	`)`
`36`	`36`	`)`
`@@ -61,7 +61,7 @@ predicate mayBeReturnZero(Function fn) {`
`61`	`61`	`fn.hasName(["getc", "atoi"])`
`62`	`62`	`}`
`63`	`63`
`64`		-/** The function returns Guard which compares the expression `bound` */
	`64`	+/** Gets the Guard which compares the expression `bound` */
`65`	`65`	`pragma[inline]`
`66`	`66`	`GuardCondition checkByValue(Expr bound, Expr val) {`
`67`	`67`	`exists(GuardCondition gc \|`
`@@ -178,7 +178,7 @@ predicate checkConditions2(Expr div, Expr divVal, float changeInt2) {`
`178`	`178`	`)`
`179`	`179`	`}`
`180`	`180`
`181`		-/** The function returns the value of the difference or summand from the expression `src`. */
	`181`	+/** Gets the value of the difference or summand from the expression `src`. */
`182`	`182`	`float getValueOperand(Expr src, Expr e1, Expr e2) {`
`183`	`183`	`src.(SubExpr).hasOperands(e1, e2) and`
`184`	`184`	`result = e2.getValue().toFloat()`
`@@ -194,7 +194,7 @@ Expr getMulDivOperand(Expr e1) {`
`194`	`194`	`result = e1.(DivExpr).getLeftOperand()`
`195`	`195`	`}`
`196`	`196`
`197`		`-/** Class that defines possible variants of the division expression or the search for the remainder. */`
	`197`	`+/** The class that defines possible variants of the division expression or the search for the remainder. */`
`198`	`198`	`class MyDiv extends Expr {`
`199`	`199`	`MyDiv() {`
`200`	`200`	`this instanceof DivExpr or`