JS: Ignore delete expressions in js/missing-await

asgerf · asgerf · commit 3a9d047cf59c · 2020-04-02T11:35:09.000+01:00
diff --git a/javascript/ql/src/Expressions/MissingAwait.ql b/javascript/ql/src/Expressions/MissingAwait.ql
@@ -45,7 +45,8 @@ predicate isBadPromiseContext(Expr expr) {
   or
   exists(UnaryExpr e |
     expr = e.getOperand() and
-    not e instanceof VoidExpr
+    not e instanceof VoidExpr and
+    not e instanceof DeleteExpr
   )
   or
   expr = any(UpdateExpr e).getOperand()
diff --git a/javascript/ql/test/query-tests/Expressions/MissingAwait/MissingAwait.expected b/javascript/ql/test/query-tests/Expressions/MissingAwait/MissingAwait.expected
@@ -1,4 +1,3 @@
-| tsTest.ts:4:12:4:19 | cache[x] | Missing await. This value is always a promise. |
 | tst.js:8:9:8:13 | thing | Missing await. The value 'thing' is always a promise. |
 | tst.js:10:9:10:13 | thing | Missing await. The value 'thing' is always a promise. |
 | tst.js:12:15:12:19 | thing | Missing await. The value 'thing' is always a promise. |

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-\| tsTest.ts:4:12:4:19 \| cache[x] \| Missing await. This value is always a promise. \|`
`2`	`1`	`\| tst.js:8:9:8:13 \| thing \| Missing await. The value 'thing' is always a promise. \|`
`3`	`2`	`\| tst.js:10:9:10:13 \| thing \| Missing await. The value 'thing' is always a promise. \|`
`4`	`3`	`\| tst.js:12:15:12:19 \| thing \| Missing await. The value 'thing' is always a promise. \|`