Review feeback for OpenStream

p- · p- · commit 3de00443fff8 · 2020-03-27T17:06:58.000+01:00
diff --git a/java/ql/src/experimental/Security/CWE/CWE-036/OpenStream.ql b/java/ql/src/experimental/Security/CWE/CWE-036/OpenStream.ql
@@ -16,11 +16,9 @@ class URLConstructor extends ClassInstanceExpr {
 
   Expr stringArg() {
     // Query only in URL's that were constructed by calling the single parameter string constructor.
-    if
-      this.getConstructor().getNumberOfParameters() = 1 and
-      this.getConstructor().getParameter(0).getType().getName() = "String"
-    then result = this.getArgument(0)
-    else none()
+    this.getConstructor().getNumberOfParameters() = 1 and
+    this.getConstructor().getParameter(0).getType() instanceof TypeString
+    and result = this.getArgument(0)
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,9 @@ class URLConstructor extends ClassInstanceExpr {`
`16`	`16`
`17`	`17`	`Expr stringArg() {`
`18`	`18`	`// Query only in URL's that were constructed by calling the single parameter string constructor.`
`19`		`- if`
`20`		`- this.getConstructor().getNumberOfParameters() = 1 and`
`21`		`- this.getConstructor().getParameter(0).getType().getName() = "String"`
`22`		`- then result = this.getArgument(0)`
`23`		`- else none()`
	`19`	`+ this.getConstructor().getNumberOfParameters() = 1 and`
	`20`	`+ this.getConstructor().getParameter(0).getType() instanceof TypeString`
	`21`	`+ and result = this.getArgument(0)`
`24`	`22`	`}`
`25`	`23`	`}`
`26`	`24`