Delete trivial tests

jorgectf · jorgectf · commit 3fd11298958e · 2021-06-28T20:18:31.000+02:00
diff --git a/python/ql/test/experimental/query-tests/Security/CWE-943/flask_mongoengine_good.py b/python/ql/test/experimental/query-tests/Security/CWE-943/flask_mongoengine_good.py
@@ -30,7 +30,7 @@ def get_db_find():
     safe_search = sanitize(json_search)
 
     retrieved_db = db.get_db()
-    data = retrieved_db["Movie"].find({'name': safe_search})
+    return retrieved_db["Movie"].find({'name': safe_search})
 
 # if __name__ == "__main__":
 #     app.run(debug=True)
diff --git a/python/ql/test/experimental/query-tests/Security/CWE-943/flask_pymongo_bad.py b/python/ql/test/experimental/query-tests/Security/CWE-943/flask_pymongo_bad.py
@@ -11,7 +11,7 @@ def home_page():
     unsafe_search = request.args['search']
     json_search = json.loads(unsafe_search)
 
-    data = mongo.db.user.find({'name': json_search})
+    return mongo.db.user.find({'name': json_search})
 
 # if __name__ == "__main__":
 #     app.run(debug=True)
diff --git a/python/ql/test/experimental/query-tests/Security/CWE-943/flask_pymongo_good.py b/python/ql/test/experimental/query-tests/Security/CWE-943/flask_pymongo_good.py
@@ -13,7 +13,7 @@ def home_page():
     json_search = json.loads(unsafe_search)
     safe_search = sanitize(json_search)
 
-    data = mongo.db.user.find({'name': safe_search})
+    return mongo.db.user.find({'name': safe_search})
 
 # if __name__ == "__main__":
 #    app.run(debug=True)
diff --git a/python/ql/test/experimental/query-tests/Security/CWE-943/mongoengine_bad.py b/python/ql/test/experimental/query-tests/Security/CWE-943/mongoengine_bad.py
@@ -21,22 +21,6 @@ def connect_find():
     db = me.connect('mydb')  
     return db.movie.find({'name': json_search})
 
-@app.route("/connection_connect_find")
-def connection_connect_find():
-    unsafe_search = request.args['search']
-    json_search = json.loads(unsafe_search)
-
-    db = connect('mydb')
-    return db.movie.find({'name': json_search})
-
-@app.route("/get_db_find")
-def get_db_find():
-    unsafe_search = request.args['search']
-    json_search = json.loads(unsafe_search)
-
-    db = me.get_db()
-    return db.movie.find({'name': json_search})
-
 @app.route("/connection_get_db_find")
 def connection_get_db_find():
     unsafe_search = request.args['search']
diff --git a/python/ql/test/experimental/query-tests/Security/CWE-943/mongoengine_good.py b/python/ql/test/experimental/query-tests/Security/CWE-943/mongoengine_good.py
@@ -23,15 +23,6 @@ def connect_find():
     db = me.connect('mydb')  
     return db.movie.find({'name': json_search})
 
-@app.route("/connection_connect_find")
-def connection_connect_find():
-    unsafe_search = request.args['search']
-    json_search = json.loads(unsafe_search)
-    safe_search = sanitize(json_search)
-
-    db = connect('mydb')
-    return db.movie.find({'name': json_search})
-
 @app.route("/subclass_objects")
 def subclass_objects():
     unsafe_search = request.args['search']
@@ -40,15 +31,6 @@ def subclass_objects():
 
     return Movie.objects(__raw__=safe_search)
 
-@app.route("/get_db_find")
-def get_db_find():
-    unsafe_search = request.args['search']
-    json_search = json.loads(unsafe_search)
-    safe_search = sanitize(json_search)
-
-    db = me.get_db()
-    return db.movie.find({'name': safe_search})
-
 @app.route("/connection_get_db_find")
 def connection_get_db_find():
     unsafe_search = request.args['search']
diff --git a/python/ql/test/experimental/query-tests/Security/CWE-943/pymongo_bad.py b/python/ql/test/experimental/query-tests/Security/CWE-943/pymongo_bad.py
@@ -11,7 +11,7 @@ def home_page():
     unsafe_search = request.args['search']
     json_search = json.loads(unsafe_search)
 
-    data = client.db.collection.find_one({'data': json_search})
+    return client.db.collection.find_one({'data': json_search})
 
 # if __name__ == "__main__":
 #     app.run(debug=True)
diff --git a/python/ql/test/experimental/query-tests/Security/CWE-943/pymongo_good.py b/python/ql/test/experimental/query-tests/Security/CWE-943/pymongo_good.py
@@ -13,7 +13,7 @@ def home_page():
     json_search = json.loads(unsafe_search)
     safe_search = sanitize(json_search)
 
-    data = client.db.collection.find_one({'data': safe_search})
+    return client.db.collection.find_one({'data': safe_search})
 
 # if __name__ == "__main__":
 #     app.run(debug=True)
