minor fixes

erik-krogh · erik-krogh · commit 41bdd8f4da7f · 2022-04-13T10:11:07.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/ResourceExhaustionCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/ResourceExhaustionCustomizations.qll
@@ -28,9 +28,7 @@ module ResourceExhaustion {
   abstract class Sanitizer extends DataFlow::Node { }
 
   /** A source of remote user input, considered as a data flow source for resource exhaustion vulnerabilities. */
-  class RemoteFlowSourceAsSource extends Source {
-    RemoteFlowSourceAsSource() { this instanceof RemoteFlowSource }
-  }
+  class RemoteFlowSourceAsSource extends Source instanceof RemoteFlowSource { }
 
   /**
    * A node that determines the repetitions of a string, considered as a data flow sink for resource exhaustion vulnerabilities.
diff --git a/javascript/ql/src/Security/CWE-770/examples/ResourceExhaustion_array.js b/javascript/ql/src/Security/CWE-770/examples/ResourceExhaustion_array.js
@@ -4,7 +4,7 @@ var http = require("http"),
 var server = http.createServer(function(req, res) {
 	var size = parseInt(url.parse(req.url, true).query.size);
 
-	let dogs = new Array(size).fill(x => "dog"); // BAD
+	let dogs = new Array(size).fill("dog"); // BAD
 
 	// ... use the dog
 });
diff --git a/javascript/ql/src/Security/CWE-770/examples/ResourceExhaustion_array_fixed.js b/javascript/ql/src/Security/CWE-770/examples/ResourceExhaustion_array_fixed.js
@@ -10,7 +10,7 @@ var server = http.createServer(function(req, res) {
 		return;
 	}
 
-	let dogs = new Array(size).fill(x => "dog"); // GOOD
+	let dogs = new Array(size).fill("dog"); // GOOD
 
 	// ... use the dogs
 });

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ var server = http.createServer(function(req, res) {`
`10`	`10`	`return;`
`11`	`11`	`}`
`12`	`12`
`13`		`- let dogs = new Array(size).fill(x => "dog"); // GOOD`
	`13`	`+ let dogs = new Array(size).fill("dog"); // GOOD`
`14`	`14`
`15`	`15`	`// ... use the dogs`
`16`	`16`	`});`