Merge pull request #892 from hvitved/csharp/get-arg-for-param-bad-magic

calumgrant · web-flow · commit 4274bb136ffb · 2019-02-07T10:50:21.000Z
C#: Prevent bad magic in `getArgumentForParameter()`
diff --git a/csharp/ql/src/semmle/code/csharp/exprs/Call.qll b/csharp/ql/src/semmle/code/csharp/exprs/Call.qll
@@ -76,6 +76,7 @@ class Call extends DotNet::Call, Expr, @call {
    * }
    * ```
    */
+  pragma[nomagic]
   override Expr getArgumentForParameter(DotNet::Parameter p) {
     getTarget().getAParameter() = p and
     (

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,7 @@ class Call extends DotNet::Call, Expr, @call {`
`76`	`76`	`* }`
`77`	`77`	* ```
`78`	`78`	`*/`
	`79`	`+ pragma[nomagic]`
`79`	`80`	`override Expr getArgumentForParameter(DotNet::Parameter p) {`
`80`	`81`	`getTarget().getAParameter() = p and`
`81`	`82`	`(`