JS: Handle IIFE parameters

asger-semmle · asger-semmle · commit 44f7e2d5c59e · 2019-07-23T17:14:56.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/JSDoc.qll b/javascript/ql/src/semmle/javascript/JSDoc.qll
@@ -430,6 +430,8 @@ module JSDoc {
         or
         ref = def.getTarget() and
         result = def.getSource().flow()
+        or
+        result = DataFlow::parameterNode(def)
       )
     }
 
diff --git a/javascript/ql/test/library-tests/JSDoc/NameResolution/bar.js b/javascript/ql/test/library-tests/JSDoc/NameResolution/bar.js
@@ -6,3 +6,10 @@ function test() {
    */
   function f(foo) {}
 }
+
+(function(iife) {
+  /**
+   * @param {iife.Foo} foo
+   */
+  function f(foo) {}
+})(IIFE);
diff --git a/javascript/ql/test/library-tests/JSDoc/NameResolution/test.expected b/javascript/ql/test/library-tests/JSDoc/NameResolution/test.expected
@@ -1,4 +1,5 @@
 | bar.js:5:14:5:18 | x.Foo | ns.very.long.namespace.Foo |
+| bar.js:12:14:12:21 | iife.Foo | IIFE.Foo |
 | closure.js:8:12:8:28 | goog.net.SomeType | goog.net.SomeType |
 | closure.js:9:12:9:23 | net.SomeType | goog.net.SomeType |
 | closure.js:10:12:10:19 | SomeType | goog.net.SomeType |

Original file line number	Diff line number	Diff line change
`@@ -430,6 +430,8 @@ module JSDoc {`
`430`	`430`	`or`
`431`	`431`	`ref = def.getTarget() and`
`432`	`432`	`result = def.getSource().flow()`
	`433`	`+ or`
	`434`	`+ result = DataFlow::parameterNode(def)`
`433`	`435`	`)`
`434`	`436`	`}`
`435`	`437`