Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 466e0cf

Browse files
tamasvajktamasvajk
committed
C#: Remove naming styles from editor config, add IDE diagnostic severities
1 parent ec6ed90 commit 466e0cf

1 file changed

Lines changed: 38 additions & 35 deletions

File tree

‎csharp/.editorconfig‎

Lines changed: 38 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Taken as is from https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference?view=vs-2019
2+
# Naming rules are removed.
23
# Customizations are added at the bottom of the file.
34

45
# Remove the line below if you want to inherit .editorconfig settings from higher directories
@@ -15,12 +16,12 @@ indent_style = space
1516
tab_width = 4
1617

1718
# New line preferences
18-
end_of_line = {cr|lf|crlf}
19+
end_of_line = {cr|lf|crlf} # we should use what git uses
1920
insert_final_newline = true
2021

2122
#### .NET Coding Conventions ####
2223

23-
# Organize usings
24+
# Organize usings - not specified
2425
# dotnet_separate_import_directive_groups = false
2526
# dotnet_sort_system_directives_first = false
2627

@@ -158,55 +159,57 @@ csharp_space_between_square_brackets = false
158159
csharp_preserve_single_line_blocks = true
159160
csharp_preserve_single_line_statements = true
160161

161-
#### Naming styles ####
162+
## The below are taken from Roslyn: https://github.com/dotnet/roslyn/blob/master/.editorconfig
162163

163-
# Naming rules
164+
# IDE0055: Fix formatting
165+
dotnet_diagnostic.IDE0055.severity = warning
166+
167+
# IDE0011: Add braces
168+
csharp_prefer_braces = when_multiline:warning
169+
# NOTE: We need the below severity entry for Add Braces due to https://github.com/dotnet/roslyn/issues/44201
170+
dotnet_diagnostic.IDE0011.severity = warning
171+
172+
# IDE0040: Add accessibility modifiers
173+
dotnet_diagnostic.IDE0040.severity = warning
164174

165-
dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
166-
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
167-
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
175+
# CONSIDER: Are IDE0051 and IDE0052 too noisy to be warnings for IDE editing scenarios? Should they be made build-only warnings?
176+
# IDE0051: Remove unused private member
177+
dotnet_diagnostic.IDE0051.severity = warning
168178

169-
dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
170-
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
171-
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
179+
# IDE0052: Remove unread private member
180+
dotnet_diagnostic.IDE0052.severity = warning
172181

173-
dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
174-
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
175-
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
182+
# IDE0059: Unnecessary assignment to a value
183+
dotnet_diagnostic.IDE0059.severity = warning
176184

177-
# Symbol specifications
185+
# IDE0060: Remove unused parameter
186+
dotnet_diagnostic.IDE0060.severity = warning
178187

179-
dotnet_naming_symbols.interface.applicable_kinds = interface
180-
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
181-
dotnet_naming_symbols.interface.required_modifiers =
188+
# CA1822: Make member static
189+
dotnet_diagnostic.CA1822.severity = warning
182190

183-
dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
184-
dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
185-
dotnet_naming_symbols.types.required_modifiers =
191+
# IDE0035: Remove unreachable code
192+
dotnet_diagnostic.IDE0035.severity = warning
186193

187-
dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
188-
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
189-
dotnet_naming_symbols.non_field_members.required_modifiers =
194+
# IDE0036: Order modifiers
195+
dotnet_diagnostic.IDE0036.severity = warning
190196

191-
# Naming styles
197+
# IDE0043: Format string contains invalid placeholder
198+
dotnet_diagnostic.IDE0043.severity = warning
192199

193-
dotnet_naming_style.pascal_case.required_prefix =
194-
dotnet_naming_style.pascal_case.required_suffix =
195-
dotnet_naming_style.pascal_case.word_separator =
196-
dotnet_naming_style.pascal_case.capitalization = pascal_case
200+
# IDE0044: Make field readonly
201+
dotnet_diagnostic.IDE0044.severity = warning
197202

198-
dotnet_naming_style.begins_with_i.required_prefix = I
199-
dotnet_naming_style.begins_with_i.required_suffix =
200-
dotnet_naming_style.begins_with_i.word_separator =
201-
dotnet_naming_style.begins_with_i.capitalization = pascal_case
203+
# Prefer "var" everywhere
204+
dotnet_diagnostic.IDE0007.severity = suggestion
205+
csharp_style_var_for_built_in_types = true:suggestion
206+
csharp_style_var_when_type_is_apparent = true:suggestion
207+
csharp_style_var_elsewhere = true:suggestion
202208

203209
#
204210
# Customizations
205211
#
206212

207-
# IDE0055: Fix formatting
208-
dotnet_diagnostic.IDE0055.severity = warning
209-
210213
[extractor/Semmle.Extraction/Tuples.cs,
211214
extractor/Semmle.Extraction.CSharp/Tuples.cs,
212215
extractor/Semmle.Extraction.CIL/Tuples.cs]

0 commit comments

Comments
 (0)