Switch to simpler synthetic field model

joefarebrother · joefarebrother · commit 46eec3c8eb44 · 2021-09-16T15:23:00.000+01:00
diff --git a/java/ql/lib/semmle/code/java/frameworks/guava/Collections.qll b/java/ql/lib/semmle/code/java/frameworks/guava/Collections.qll
@@ -585,35 +585,3 @@ class TableType extends RefType {
     )
   }
 }
-
-private class TableRowField extends SyntheticField {
-  override predicate fieldSpec(RefType owningType, string fieldName, Type fieldType) {
-    owningType.hasQualifiedName(guavaCollectPackage(), "Table") and
-    fieldName = "rowKey" and
-    fieldType instanceof TypeObject
-  }
-}
-
-private class TableColumnField extends SyntheticField {
-  override predicate fieldSpec(RefType owningType, string fieldName, Type fieldType) {
-    owningType.hasQualifiedName(guavaCollectPackage(), "Table") and
-    fieldName = "columnKey" and
-    fieldType instanceof TypeObject
-  }
-}
-
-private class MapDifferenceLeftField extends SyntheticField {
-  override predicate fieldSpec(RefType owningType, string fieldName, Type fieldType) {
-    owningType.hasQualifiedName(guavaCollectPackage(), "MapDifference") and
-    fieldName = "left" and
-    fieldType instanceof TypeObject
-  }
-}
-
-private class MapDifferenceRightField extends SyntheticField {
-  override predicate fieldSpec(RefType owningType, string fieldName, Type fieldType) {
-    owningType.hasQualifiedName(guavaCollectPackage(), "MapDifference") and
-    fieldName = "right" and
-    fieldType instanceof TypeObject
-  }
-}
