Quality improvement: add explicit this in QL

tamasvajk · atorralba · igfoo · commit 48b6c61fdbbe · 2022-05-10T19:51:26.000+01:00
Co-authored-by: Tony Torralba &lt;atorralba@users.noreply.github.com&gt;
diff --git a/java/ql/lib/semmle/code/java/Expr.qll b/java/ql/lib/semmle/code/java/Expr.qll
@@ -1994,7 +1994,7 @@ class ExtensionMethodAccess extends MethodAccess {
   // whereas the actual arguments begin at index 1.
   override Expr getQualifier() { result.isNthChildOf(this, 0) }
 
-  override Expr getAnArgument() { result = getArgument(_) }
+  override Expr getAnArgument() { result = this.getArgument(_) }
 
   override Expr getArgument(int index) { result = super.getArgument(index + 1) and index >= 0 }
 }

Original file line number	Diff line number	Diff line change
`@@ -1994,7 +1994,7 @@ class ExtensionMethodAccess extends MethodAccess {`
`1994`	`1994`	`// whereas the actual arguments begin at index 1.`
`1995`	`1995`	`override Expr getQualifier() { result.isNthChildOf(this, 0) }`
`1996`	`1996`
`1997`		`- override Expr getAnArgument() { result = getArgument(_) }`
	`1997`	`+ override Expr getAnArgument() { result = this.getArgument(_) }`
`1998`	`1998`
`1999`	`1999`	`override Expr getArgument(int index) { result = super.getArgument(index + 1) and index >= 0 }`
`2000`	`2000`	`}`