Java: Add test for sanitization using toAbsolutePath().

aschackmull · aschackmull · commit 4953e4923a36 · 2018-10-31T11:38:27.000+01:00
diff --git a/java/ql/test/query-tests/security/CWE-022/semmle/tests/ZipTest.java b/java/ql/test/query-tests/security/CWE-022/semmle/tests/ZipTest.java
@@ -41,4 +41,14 @@ public void m4(ZipEntry entry, File dir) {
     validate(dir, file);
     FileOutputStream os = new FileOutputStream(file); // OK
   }
+
+  public void m5(ZipEntry entry, File dir) {
+    String name = entry.getName();
+    File file = new File(dir, name);
+    Path absfile = file.toPath().toAbsolutePath().normalize();
+    Path absdir = dir.toPath().toAbsolutePath().normalize();
+    if (!absfile.startsWith(absdir))
+      throw new Exception();
+    FileOutputStream os = new FileOutputStream(file); // OK
+  }
 }
