JS: Avoid materializing DataFlow::Node.getFile

asger-semmle · asger-semmle · commit 498e4d2d5747 · 2019-07-23T17:14:56.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/GlobalAccessPaths.qll b/javascript/ql/src/semmle/javascript/GlobalAccessPaths.qll
@@ -112,7 +112,8 @@ module GlobalAccessPath {
     exists(DataFlow::Node rhs |
       fromRhs(rhs) = accessPath and
       not isSelfAssignment(rhs) and
-      rhs.getFile() = file
+      // Note: Avoid unneeded materialization of DataFlow::Node.getFile()
+      rhs.getAstNode().getFile() = file
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,8 @@ module GlobalAccessPath {`
`112`	`112`	`exists(DataFlow::Node rhs \|`
`113`	`113`	`fromRhs(rhs) = accessPath and`
`114`	`114`	`not isSelfAssignment(rhs) and`
`115`		`- rhs.getFile() = file`
	`115`	`+ // Note: Avoid unneeded materialization of DataFlow::Node.getFile()`
	`116`	`+ rhs.getAstNode().getFile() = file`
`116`	`117`	`)`
`117`	`118`	`}`
`118`	`119`